v6 - progress towards diagnosing and fixing stuff, 1.6 version is back

anyone reading this, ive rolled it back to just 1.5 for a bit holup im fixing it

@Tinda I AM NOT ALONE

@carni I THOUGHT I WAS GOING CRAZY

Oh that explains it.
I've been redownloadning it like 5 times lol

@carni Yeah working on it, had to roll back a bit

After the last update the mod doesn't display compatibility with 1.6 anymore.

@«PeGaS» Really? Oh shit, lemme look into this

Hmm, there are changes after all, I checked the dll itself and its way smaller mow, without extra harmony patches.

@ferny Thank you, I really have no idea why this is the case, as Im a modder myself (for custom project) and have no clues why this update would do such a thing, as there are no changes for 1.5, so I guessed maybe you can tell me.

@«PeGaS» I've got thousands of folks in my server nobody's said a word on this, but I'll look into it regardless

Really dunno why though, I double-checked mod folder, tried load folder file to point to the 1.5 assembly, nothing.

I'm sure, all my patches just died the moment I started the game after 10 days off, restart didn't fix it, but the older version (from March) is working fine.

Just double checked, haven't modified ReplaceLib.dll since February first which was last update

@«PeGaS» Are you absolutely sure of that? Nothing has changed about the 1.5 version

After the latest update, all patches now broken on 1.5, had to download older version before update

v4 - updated to 1.6

@Polat Alemdar My friend the removal of the rustic table is intentional, it has been ported to the new Old-World style. As for the errors, they're from recent updates to other mods, they're all harmless but will be fixed soon.

ok my bad problem wasnt replaceLib but it was:
Progression: Aesthetics https://steamcommunity.com/sharedfiles/filedetails/?id=3294950875

here is a screenshot in game:
https://prnt.sc/MrZdtSbpB6wd

red lines:
https://prnt.sc/ZC-Ywi5LVYP_

logs:
https://justpaste.it/cjzu8

modlist:
https://prnt.sc/JhNVCpIZCxra

@Polat Alemdar Nope

There is an issue with medieval overhaul, this mod removes option to build some of furniture, for example rustic table (1x2)

@Ferret With A Cat Hat Patch Operation Collection has a DefNameLink operation that does include a defType field to work with all def kinds. That can achieve the same effect, wouldn't need dependencies either.
Stuffable floors simply generates more terrain defs through C#. It doesn't remove them

Is there any way to make this work with terrain? I've made a mod that unifies the stone types using this but this mod can't unify anything other than things and whilst i felt removing the other stone block recipes would be fine removing the other floors would probably lead to all sorts of issues

do i just use stuffed floors or smth

@Vulkandrache Probably not?

Is this likely going to cause problems with mod like
https://steamcommunity.com/sharedfiles/filedetails/?id=2542931556
and
https://steamcommunity.com/sharedfiles/filedetails/?id=2591816333
that change large amounts of thingdef already?

@furel87 This is for ThingDefs

Does this work with memes and precepts? I did a substitution as Def and as Patch and neither of them seem to work. Precepts seems to not recognize the substitution and asks for the overridden meme

getting error at the start https://gist.github.com/HugsLibRecordKeeper/c7d93b4de06a8e40629991dfbfe04fcd

@LikewiseHH Look at the patch i did for Medieval Overhaul in my mod Progression Agriculture, that's a functioning one that you can look at for example

Thanks for your help. Still could not manage to get it to work though. Is there a github repo or so with examples from which I can learn?

@LikewiseHH You are going to want to make this a def. Put it in your defs folder, not your patches. If you want you can make it a patch by doing a patchoperationadd def, but just use the defs folder for this I think it looks simple.

Hmm still struggling @ferny. Don't wanna hijack this for troubleshooting but maybe you can quickly help out:
I have my own mod adding some armor. I declared your mod as a dependency. In my mod I added a 'patch_replace_defs.xml' file with this content:

<?xml version="1.0" encoding="UTF-8"?>
<ReplaceLib.ReplacerDef>
<defName>TestReplacy</defName>
<replacers>
<li>
<replace>Apparel_AdvancedHelmet</replace>
<with>T2_Helmet</with>
</li>
</replacers>
</ReplaceLib.ReplacerDef>

I would expect now not to find the Apparel_AdvancedHelmet def in the game at all anymore but it's still there. Or am I misunderstanding what the mod does?
Thanks!

@LikewiseHH Defname is irrelevant, just is a codename you designate for your replacer. The only thing that matters it the "replace" field and the "with" field which you fill with the corresponding defs

I must be stupid. How can I replace defs from the core game with my custom ones? Does "Core" go into the defName at the top?

@PeGaS release please :D

Tested with urban ruins mod to unify all my guns mods - perfect. Thank you.

I don't understand what that means, Bradson. I don't know how this works.

DefNameLink.Operation from Patch Operation Collection has a <defType> field to target other types of defs

@TurtleShroom I'm not sure actually

That's awesome. Can I also replace things like Research Project Defs and such, or does it only work with Thing Defs?

@TurtleShroom Removes the def as well

Does making a Replacement Def remove the object being replaced, or does it just add this one?

Can I use it to patch custom defs? Will it work with maps layout defs with thousands of li tags?

Does this only replace Thing Defs?

v3 - improved performance

Nice work!

v2 - fixed recipes issue

*oh man. oops.

Oh many this might get me into modding then. Messing with files has always been a bit overwhelming so having some safety bars would be nice. Thanks!

@M0rr1s0n Medieval Overhaul related patches with this mod coming soon!