Divinity: Original Sin 2

Divinity: Original Sin 2

Reforge
This topic has been locked
Luduaver Jun 4, 2022 @ 10:05am
Item disappearing after trying to reforge
I tried using Tank Augment on Captain's Charismatic Coat and the item just disappears after use.
The log below was made using reforge on the workbench
I also tried through the craft menu, but I didn't see the log, but the item also disappears.

Crash Log[i.imgur.com]

It's not every time the item disappears, sometimes it disappears and sometimes it doesn't. I'm using osiris v55.
Last edited by Luduaver; Jun 4, 2022 @ 10:08am
< >
Showing 1-2 of 2 comments
Focus  [developer] Jun 4, 2022 @ 2:39pm 
One of the stats on the Captain's Coat is trying to reforge into an On-Contact status effect, but the base value for the stat is nil despite specifically checking if it's not nil. The proceeding logic tries to find a numeric representation of this nil value, which it's not equipped to do, and this causes a further cascade of issues that causes the Reforge to fail.

The item always disappears as part of a quirk of crafting with "ComboProperties". These are aggregates of items that you can map individual outcomes to. So I could place several different items into a "Water" ComboProperty and map an output for each of those items when they're used in a recipe. So if one of the "Water" items was a cup of water, that could be mapped to give an empty cup, a bucket could give an empty bucket, and so on. But all of these "full-of-water" items will satisfy as an ingredient in a recipe that is using the "Water" ComboProperty. This dramatically cuts down on the required number of recipes, as well as makes a ton of UI stuff far more convenient. The initial item is *always* consumed for a ComboProperty though, even if there is no output item.

In the case of Reforge, pieces of equipment are part of a Reforge-only ComboProperty. The piece of equipment undergoes the reforging processing just before it's consumed, creating a new item that contains the changes from reforge. The new item is put into the character's inventory and the old item is consumed as part of the craft. When the reforging process fails, no new item is created and so all that happens is the craft is "successful" and the original equipment is consumed.

I'll take a look at this today and figure out what is causing the failure.
Last edited by Focus; Jun 4, 2022 @ 2:58pm
Focus  [developer] Jun 4, 2022 @ 4:11pm 
Problem was identified and fixed.
< >
Showing 1-2 of 2 comments
Per page: 1530 50