@dmc32:
Add to the nickname list in XComGame.int

Those are per class.

@thade, is there a way to add names to the list of generated names?

@thade well i was thinking about the colors , something like puting an RBG code before generating a weapon name , so the weapon will have a RED name or blue (what ever) a bit like what we can see in grimy loot box u know , normal weapons have a green name , rare go with purple name and epic is gold .

Hi @onestrongbow! What do you mean? If you mean literally change the color of the letters, not without a LOT of work. If you mean "more interesting" Yes. As I recall, the weapon name gen uses the same name list as the class of soldier wielding it (or at least the one that would wield it in vanilla) so if you pull down new nickname lists or edit them yourself, you should see those pop up.

any way to make the new weapon nickname a colorfull one ?

Thank you mate =)

@Gleen Cross Ha! uuhhh I guess I can do that, it's kind of a lot. I'll set up a collection or something.

@thade can you post your mod list? Sorry to bother, I am trying some combinations, but the game still crashes =/ It worked flawless some months ago

Definitely still working for me with my metric ton of mods, @Gleen Cross. :( Sorry you've having trouble.

I tried it out with a sniper, then again with a ranger... it did not worked. It's weird because I used this mod some months ago and it worked fine, I wonder if the recent updates broke the mod. But the mod is still working for you two, so the problem is on my end it seems. I will try the troubleshooting later, I'm getting constant ctds with this game =/

I'm pretty sure the soldier needs to have a class (not be a rookie) as all nickname generation in XCOM 2 is tied to a charcter's class (including weapons) so if they don't have a class yet, they have no nickname table to draw on.

So...what weapon type were you trying to rename? And what character class? And do you have any other mods for weapons/weapon mods (e.g. Grimy's kind of stuff)?

@Green Cross

@Gleen Cross:
Odd, works fine for me in WotC. The weapon didn't get a name then? Does the class of soldier the weapon was equipped on have a set of nicknames defined? That seems to be where the names are pulled from.

Some of the material in these guides may help:
Troubleshooting: Mods not working properly / at all
Mod not working? Mods still have their effects after you disable them?
And if you use the Firaxis launcher: https://www.reddit.com/r/xcom2mods/wiki/wotc_modding/guides/fix_duplicateactivemod

I tried it out with WOTC, the button appeared... but after I clicked on it, nothing happens.

Fabulous mod. Now I name all the weapons that get upgrades.

@bookage1:
According to the mod compatibility list on Reddit, yes.

Wotc compatible?

Thank you, @hygorct, on both counts :)

@thade
i will find a time to test...
thx.
congrats about your second son... and good lucky with your wife...
my mother finished the treatments 3 months ago...
everything is gonna be alright friend :)

To be honest with you, I haven't had time to really test it out; I suspect it doesn't due to the amount of changes LW2 made to the weapon mods and underlying systems there, but it might. (My wife gave birth to our second son two weeks ago and is resuming chemo treatments for breast cancer this week, so I've had perfectly zero time for hobby development.)

To test it for the community, if you feel motivated, fire up only LW2 and this mod together and see whether the button is present and whether it works. Remember it'll only work for soldiers that can themselves have nicknames, so Rookies won't see the button at all (if they do, it's a bug, and probably won't work).

compatible with LW2?

does this work with LW2?

@SirConnery, my random appearance mod actually does what you're requesting: if you lock all other attributes on the soldier but the gun, you get your desired effect.

Still, having it work on the weapons screen (for named weapon) would be neat. I won't have time to look into this in the short term, but maybe one day. :)

Could it be possible to create a random appearance mod for weapons? Where it picks a random color + pattern.

My ideal would also be for automatic naming of weapons. Where if you pick a repeater on an Assault Rifle it always names it to a specific name, like Repeater. If you place a stock on any weapon it names it Guaranteed.
With names being configurable in the ini file.

Just some thoughts.

cool

Historically it did, yea, thanks to assist from @/dev/null.

Does this work with Mod Everything?

Been working fine for me in my most recent playthrough, named a few weapons yesterday in fact.

@Jeff George. It won't work for Rookies (i.e. soldiers who don't yet have a class designation) although it should be greyed out for those soldiers. If you find it won't work for soldiers who have been ranked up, then you've likely got a conflict on your hands, I'm afraid.

That stinks. I do see the button but when I click it there is an appearance of a response but nothing ever appears in the name box.

@Jeff George, it's working for me! haha. I was using it yesterday while playing around with all of the new LW mods. Works with my other typical mods too. You might be seeing a mod conflict, unfortunately. :\

Is this working for anybody?

This might bear additional investigation at this point on my part: maybe it's a smaller effort than I realize to leverage a custom weapons name list, but I have severe doubts. :) I'm moving in two weeks, but after the dust settles I can drill in. If anybody else does before hand and you find something, ping me!

Hi @Dragon32.

I *believe* that the function used to generate nicknames for weapons uses the same lists that the soldier nickname function uses, which are all arranged by class in the INI file. (I forget which one offhand.) It's possible that it's a subset or has some other filter (i.e. not the full list that the soldier name function uses) but I didn't drill down far enough to know for certain beyond the "Rookies can't have nicknames" limitation that the two functions share.

Thus, neither GenerateNickname method will return a name for a Rookie or a Rookie-class assault rifle...which is an annoying engine-only difference that the player never encounters except for mods like this.

A question on this quote of yours, thade, from 29th Feb:
I went in to do this thinking I'd need to leverage the soldier nickname code, which is selected for based on class and gender, randomize those things and fake it to get the nickname...then I found the weapon upgrade code actually has a function that does precisely that.

So... there isn't a list of weapon nicknames per se ? Rather, weapon nicknames are generated based on the soldier nickname list (which I've extended using a couple of mods).

Just wondering if there's a specific weapons list I could take a look at and see if inspiration strikes for adding to it.

Oh sweet, gonna check if it works for me.

Your mod works with grimy's loot mod, at least for me.

Though I have to report that, for a time, it stopped Extended Character Pool from working, but I got both working after deleting my config files a few times.

Praise brute force! Praise modders! Thanks for the great mod thade :D

@MoronicCinamun, If I'm understanding you correctly, it's possible that one or more of those custom/modified weapons are based (under the hood) upon the rookie rifle instead of the "non-rookie rifle" which might result in them being "immune" to how my button works. The button is greyed out when it's confronted with a rookie weapon, even though the rookie rifle is numerically and visually identical to the non-rookie assault rifle. (I know, it's weird.)

It's possible that if I can add weapon naming to rookie weapons that we win; I'll give that a go as soon as I have a chance.

Well I can get back to you now: it seems to be working.
Not sure why, just somtimes the button is greyed out. For the record, I've only really used it for weapons that I modified from "scratch" (rather than ones that came in Grimy Loot Boxes), but it certainly seems to work!

I should also mention it is an amazing mod, seeing as how I have no creativity with weapon names (WH40k Orks are more clever).

@MoronicCinamun: you can only rename weapons for soldiers that aren't rookies; the game treats rookie assault rifles as if they're different guns from non-rookie assault rifles. (I'm not sure why, but there it is.) Given that you're mid-campaing, I wouldn't expect that to be an issue though; especially if you're seeing it work inconsistently, which is very strange.

If you could get back to me after you're between campaigns (even if it's a while from now) it would be very helpful to me. :) Thanks!

Well I am afraid I to start disabling stuff without breaking stuff mid-campaign, but it did work ONCE. For some reason often is greyed out, but it worked once on a Gremlin of all things; possible conflict with the "Mod Everything" (by Grimy, prereq for Loot Mod)?

@MoronicCinamun: That's a severe bummer. I've got a few reports now that it has worked; maybe there's a recent Grimy patch that broke it? Have you tried my mod on its own and just the two mods together (with no other mods)? If it happens to be some third mod confusing mine, I'd be very interested to know. I'll have a look and see whether it's something else that's cropped up. :)

(the loot mod, that is)

Just wanted to say this doesn't seem to be working with Grimy's mod :/

@BlackVision: glad to hear it :) feedback is appreciated! I hope you enjoy it!

Looks good! Giving it a try.

@RealityMachina: My day's getting better and better by the minute. :) Thanks so much!

@thade It works.

@Married Person, thanks so much! Let me know if things work and/or get weird!

I just read your comment in grimy's mod. Re-subbed to help you bug test as well as enjoy your mod again. Hopefully I won't have to report anything, and everything works completely. :D cheers!

@IceMaverick: I think you also were interested in Grimy's Loot Mod support; I hope the patch I just added addresses that. If you don't mind trying it out, please let me know how it works or what problems it has!