@Brutalbic: Thanks for the log! I'm planning on getting back into RW modding in December, so I'll be sure to deal with this issue soon. :)

Hey ilyvion, absolutely love this mod. I am having the same issue that others are mentioning with renegotiations not working, noticed nobody actually posted their log so here's mine, the red text error starts from line 6000.
https://gist.github.com/HugsLibRecordKeeper/55c86d1a0075e564da6d9813c3b1d259

One of the main reasons I am wanting to try renegotiate is because during the transport loading process, an animal / colonist has consumed an item or used material that was supposed to be traded, so on the "to load" column it appears blank but I suspect something that was on the list is no longer there so it doesn't launch. -- not sure if this is a separate issue or if this is related to attempting a negotiation just breaking it

Happy to provide any other details or feel free to reach me on here or discord, same username :)

@StR876: Preferably using the bug report routine described in the description above.

in comments?

@StR876: Posting a log would be helpful in getting to the bottom of your problem.

so i am not only one getting tons of red text in log from this mod?

Can confirm that the renegotiation issue is real and still present.

@Jacbo: Yeah, it's something I eventually plan to make, but I'm not very actively modding at the moment; I'm mostly in "putting out fires" mode now.

Do you have any plans to do something like this for trader caravans? I'm currently looking for one and I also don't have any DLC

I have a space base and i'm using Spaceports and I have the vanilla shuttle landing location but the trading is just working the same. Im not sure why

Oh, perhaps there could be a small fee for them sending the shuttle in the first place?
A transport tax, or something, so it's not like you're wasting their time and fuel for free? You'd have to load it, though... maybe it's the first thing, and if you don't do it, you get a faction reputation hit?

Maybe the workers could be an extra option that costs a bit more, requesting some extra help with the trade?

@Vril: Indeed! It's a planned idea already, but I don't know when it'll become a reality.

Trader ship could spawn pawns to help carry the stuff with bigger orders.

@ilyvion
I haven't done that. I don't want to cheat the system or make it too easy, but it does suck when we have a potential big trade ready and we've spent half a day loading most of it, but we run out of time in the final stretch.
Perhaps a letter saying something along the lines of: "The trader is about to leave, but if you're willing to pay a small fee, they will extend their wait by x hours. Would you like to do this, or cancel the trade?"
Perhaps there could be a couple of different responses you can give, adding more time? Like, 3 hours, 6 hours, 12 hours?

@DarianStephens: I assume you've already set the grace time in the settings to the highest possible value? But yeah, I could probably add a mechanic like that.

Do you think there could be an option to extend the time a trader will wait in exchange for some extra silver or something?
Even with the whole colony on transporting, we still can't manage some particularly large trades.

@Vril: The mod uses the same code for choosing a landing spot as the vanilla Royalty shuttles; having a cleared landing pad [rimworldwiki.com] should make the shuttles favor it. If not, that's a bug in the game itself.

How i can put a landing zone/spot for the traders? They land a long way from my storage and pawns cant sell items in time - i wanted to haul 3k chemfuel.

@Marsianer: Consider using the standalone Log Publisher from HugsLib , it makes publishing a log as easy as pressing Ctrl+F12 in the game.

Symbol limit in comments section is stopping me from doing so, but I can send them to you somewhere else like email or a message in steam, sorry for your inconvenience

@Marsianer: Can you get me a full log?

There is a ton of errors after I load my save (Could not find a type named RealisticOrbitalTrade.JobDriver_RenegotiateTrade; ReflectionTypeLoadException getting types in assembly RealisticOrbitalTrade: System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.; Could not find a type named RealisticOrbitalTrade.Comps.CompTradeShuttle; Config error in ROT_TradeShuttle: ROT_TradeShuttle has CompProperties with null compClass. etc), I dont understand why and what caused them, since I dont have possibly conflicting trade mods, just trading expanded and a mod for extra silver, and I cant imagine jewelry, VVE and Map Vehicles causing those issues, because I only downloaded them before error occured

It's not lagging now

Once you have version 0.20 of my laboratory mod, if you're still getting errors, please let me know.

Yep, I've made the mistake of forgetting to update my Laboratory mod before updating the mod using it. My bad, I'm very sorry for the inconvenience. Laboratory mod updated now, should work again once it's updated for you.

RimWorld.PassingShipManager:PassingShipManagerTick consumes a lot of resources, causing the game to lag at triple speed. After I removed it, the frame rate increased by 10 and the game became less laggy

Oh, I'm not sure if this is actually related, but my game hard crashed shortly after the trade ship arrived. Not immediately, but after a few minutes maybe.
No 'stopped responding' or anything, just the game closing with no fanfare.

Removing Realistic Orbital Trade lets me load any of the saves with no issue.
With Realistic Orbital Trade still installed, I can't load a save if there's a trade ship present, it seems. However, I can load other saves made after the mod updated.

So, I'm not SURE this is an issue with your mod, but it's only showing up now.
I was able to load a save prior to the mod update just fine, but attempting to load any save made after the mod was updated leads to a 'failed to load map' error, and this log:
https://gist.github.com/HugsLibRecordKeeper/3db423eef560e2a8d6be26a78aced8ec

@ilyvion Error has gone. Thank you for the quick fix! It's a good mod and of vital importance for me :)

drop pods I mean

The only method to stop those spam is by disabling shuttle drop and minimum threshold setting

Same problem with @kyrambox, I have ilyvion's Laboratory but it's spamming errors. It's killing my run already.

@kyrambox: You're most likely missing "ilyvion's Laboratory" based on your list of mods. I see I've forgotten to add it as a required dependency, so thanks for the report and my apologies for the missing dependency entry.

I see mass red errors after last update. No active mods, except core, dlcs, harmony and this mod. ReflectionTypeLoadException getting types in assembly RealisticOrbitalTrade and many. many "Could not find a type named...."

Yeah, a pastebin is good. If you have HugsLib or the standalone HugsLib Log Publisher mod , all you need to do is press Ctrl+F12 to publish a log to a convenient location.

@ilyvion
Yeah, pressing 'Accept' just doesn't do anything. The only way out of the dialogue is to cancel.
I'll do that next time! Do you want me to send the log in that case? Should I use pastebin or something?

@Darian Stephens: When you say pressing "Accept" does nothing, does it not even close the dialog? Also, if you run the renegotiation dialog with "dev mode" enabled in the RW settings, the log should be filled with debug details about the renegotiation, so the next time you're having a problem with it, please enable dev mode and try.

Thank you for all of your work, and feel better soon.

@DarianStephens: The renegotiation feature is clearly buggy. Unfortunately I came down with a horrible cold on Monday and haven't been able to work as much on the mod as I had hoped, but the hope is that when I'm done tackling the renegotiation issues, there won't be bugs like that afterwards.

I do plan on adding some debug features in so that people who are having issues can provide me with better diagnostics when things aren't working like they should, though.

Is there any chance you might add some corner notification if renegotiating the trade fails for whatever reason?
There have been several times where I've tried to change it in some way, but pressing 'Accept' just does nothing. Having some kind of feedback would be appreciated.
I look forward to seeing what the future of this mod holds, it adds a lot of life to orbital trading!

Thank you for your dedication, I hope all your other projects are going well, wouldn't wanna distract you from bigger things.

I've got an addendum to pawns not being able to haul Genepacks from Genebanks.

If you click "Eject All" on the bank containing the Genepack you're looking for, and it happens to fall ontop of another Genebank, even though it's not stored in the Bank they won't recognize it for hauling. I had to then either manually have pawns haul it off/pick it up or deconstruct/minify the bank that the Pack is sitting ontop of.

https://gist.github.com/HugsLibRecordKeeper/81dd59baf069c6995963ef98265b9611

Alright, I've prioritized some other mods recently, but this one's clearly in need of some TLC now, so I'll be putting my efforts into this one until I think it's in a better state. Sorry about the issues y'all are experiencing, hopefully I'll be able to address them in the coming days and make this mod more enjoyable.

Actually on subsequent trades it looks more like the list of "to be loaded" isn't updated correctly, or something. I have a congoline of pawns delivering things to the shuttle and the list of what needs to be loaded is just empty.

Would also like an option to force launch, in cases like this. Ofcourse finding the issue and resolving it would be most optimal.

I was never able to successfully renegotiate the terms. Clicking "accept" just does nothing for me.

I never had it leave before the deadline, though.

Can confirm what @NeonSunset says, I was just about to report the same thing.

First time, though, where everything is loaded and the ship isn't leaving.
https://gist.github.com/HugsLibRecordKeeper/cea500cd7eba9acef1f1797bf3438b5c

I'm not quite sure if this is a bug or not, but sometimes even after the ship is fully loaded, it absolutely refuses to leave. There's no error messages or anything; it just says that I didn't meet the deadline and it returns my stuff. The thing is, I've had this happen while I've still have plenty of time on the countdown (3+ hours).

It would be wonderful if you could add some sort of "force launch" option to the shuttle so we can send it off if we've completely loaded it with extra time to spare.

@Schedenfreude: Thanks for the bug report!