o7

o7

07

o7

To anyone coming here to ask: I'm almost certainly not going to update this mod.

With fishing moving to main and the VE team already moving some of my changes into their mod, I'm going to call this one unnecessary.

hey, the background and ideology stuff are still useful, so the mods worth keeping around.

I asked them to do it for like a year and they never did, but if they did it now then that means I guess this isn't all that useful anymore.

just to inform, VFE has now added its own expertises for VSE

Updated to 1.5

based

No, the way the expertise works is that it increases the new stats that I added (Fishing Speed and Fishing Amount) and then the Fishing job that VE-Fishing added uses those stats. There is no other place for them to apply.

@Delmain: You added a skill expertise for the new fishing stats.

But the expertise is a sub-specialty of the Animal skill. The base animal skill affects the stats for hunting and taming activities but not fishing (at least according to the tool tip). To fully integrate it, the base animal skill should affect fishing as well.

@ShinUon this doesn't add a new job type, it just adds a new stat and causes the VE-Fishing worker to use it to calculate fish amount and speed.

I don't know what you mean by "add the new fishing stat to the regular animal skill" though, because this mod is specifically for VE-Fishing and I hooked into how that mod is doing it.

This is really useful for the fishing integration for the Vanilla Skills expertise.

Would it be possible to add the new fishing stats to the regular animal skill as well?

Does this add a job type? I use a mod that adds more granular job types (e.g. Work Tabs, Complex Jobs) and right after installing this mod, some of my job priorities got scrambled.

Do you think you could change the amount of nutrition fish meat has to be more in-line with the rest of the game?

I'm just glad they finally made nonviolent fishing a thing. It never made any sense to me.

I have the error with just hugslib / VEF/ VFE and your mod.

I can't use pastebin to share the log because somehow it apparently has "offensive stuff" in it O__o
And it's too long to fit in a single Steam post .... (I have a lot of mods I just deactivated them to make sure if the issue is from a bad interaction or not)

@[JdG] Pejman - Please share a log in the Bug Reports thread. I would need to know what mods you have that may be touching the same things that this mod does, and I don't get that from just a single error message. That message makes it look like some other mod is changing the same thing I am.

getting an error

Error in static constructor of DelmainTweaks.VanillaFishingExpanded.Startup: System.TypeInitializationException: The type initializer for 'DelmainTweaks.VanillaFishingExpanded.Startup' threw an exception. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidOperationException: Match not found
at DelmainTweaks.VanillaFishingExpanded.HarmonyPatches.JobDriver_Fish_Patches.JumpToMatch (HarmonyLib.CodeMatcher matcher, HarmonyLib.CodeMatch[] matches) [0x00033] in <c483720ab7b34f2092d335c9a5e4bd38>:0
at DelmainTweaks.VanillaFishingExpanded.HarmonyPatches.JobDriver_Fish_Patches.JobDriver_Fish_MakeNewToils_Transpiler (System.Collections.Generic.IEnumerable`1[T] instructions, System.Reflection.Emit.ILGenerator generator) [0x00166] in <c483720ab7b34f2092d335c9a5e4bd38>:0

@Delmain
No I was telling you, instead of a fishing rod you can make those clothes. It was an idea not a patch asking. Sorry I didn't make it clear

@Smiley Face Killer - That's from Vanilla Ideology Expanded - Memes and Structures, and I already patch that to use the stats from this mod. If you know of one from another mod, I can include a patch for it.

@Delmain
There's a fishing tackle box that goes into your utility slot. not sure which mod its from but you could make something like that, or even a fishing hat with the bits and bobs on it to help that skill or a fishing vest, hell even some waders for your legs

@Scout Gaming - There are also other mods that already do that, anyway. For example, the "Nonviolent Fishing" mod.

@Scout Gaming - No, I think that is a balance decision that I personally agree with. It makes taking non-violent pawns a decision. There is no way to get meat with a non-violent pawn, that feels right to me.

@[JdG] Pejman - Yes, the fact that they pull out a pole when they start the action is something I'm trying to look at. I haven't found a way to bring a pole in that looks good. I might do a small net instead so that the pawn is holding a net and a pole (which is realistic), but I'm still looking at it.

Will you make fishing a nonviolent job?

doesnt VFE have a fishing rod sprite already for the fishing animation ???

Awesome thanks, I'll take a look

Yea I just googled "Cartoon ish fishing rod" there's a few there that sort of barely fit rim world style and with just a little tweaking could be a good fit in honestly.
But here's the link to that specific one


https://creazilla.com/nodes/1795517-fishing-rod-clipart

Can you link where you found it so I can check licensing?

https://th.bing.com/th/id/R.de8278efa4026f75c5899c9f1b304572?rik=34FMc%2fHo5Dnemg&pid=ImgRaw&r=0

Found you one on Bing* (forgot I switched that shit tbh originally said Google)

I am exceptionally not good at art, but if I can get a texture, I'll take a look at adding it.

Suggestion : add a fishing rod tool that can be crafted which increase the new stats

I have 700 mods, I mean that's a big chance that our paths cross at some point at least lol
But yea, if I come across something I'll ask here

@Smiley Face Killer - if it's a set of mods I use, yeah. I have nearly 400 mods in my current modlist, and I've already had to do a few local patches to get things working together well. If you have an idea and it's something I already use or looks interesting, I'll take a look.

Not asking you to do so, just curious, are you planning on making more additions like this one?
I just woke up so my brains not full fast firing yet but if I come up with an idea for one, would you like me to drop it? ( the desc does say so but still figured I'd ask)

Thank you!

You did great work on this! Well done!

Phimsh