Wallpaper Engine

Wallpaper Engine

VU Meter
Tim  [developer] Jun 3, 2018 @ 2:51pm
The wallpaperPropertyListener needs to be created outside onLoad event
Hey,

I have had some issues with your wallpaper where it would only start non-functionally with a completely pink screen. This is likely due to the fact that the wallpaperPropertyListener is created in the onLoad event in the index.html after the wallpaper object is instantiated. You should try and place them outside the onLoad event, since the listeners should be created immediately.
< >
Showing 1-5 of 5 comments
Squee  [developer] Jun 3, 2018 @ 5:01pm 
I feel for you for having to read through that messy code :) But well found .. Your assumption sounds very plausible, and I will update my code. I do believe I have tested this before and notice something similar in rare case either way, but can't hurt to change it.

Another possibility is that I have some bug processing the settings causing the code to stop starting. I have had that one before in another wallpaper.

Will be asking Bio this week to be sure of how it should be because if true that would mean I would have to update a lot more than just this wallpaper. Will also update this wallpaper in the coming days.
Biohazard  [developer] Jun 4, 2018 @ 2:28am 
Hey Squee,
the issue with window.onload is true, but I don't think it's currently the prevalent cause. While I'm actually waiting for a 'load ended' event in C++ before sending any properties too, it is different from window.onload, so the order of things still isn't guaranteed. So it's best to just set up the listener object right away. (My understanding is that window.onload will also wait for all dependencies while the C++ callback won't.)

Since the last time I updated Chromium I noticed this happening even more often than before when switching between two web wallpapers quickly. It seems the callbacks I'm waiting for don't allow me to check whether they belong to the last page I loaded, so the properties never reach the most recently selected web wallpaper. I think I already have a work around for that issue though.
Squee  [developer] Jun 6, 2018 @ 9:34am 
Woah :spazhorror: you already found me before I got to ask on forum .. spooky

Thanks for the feedback .. will update all my wallpapers to start different and not wait for window.onload.
Biohazard  [developer] Jun 6, 2018 @ 11:27am 
Originally posted by Squee:
Woah :spazhorror: you already found me before I got to ask on forum .. spooky

That's because ultio is a friend of mine :eaglegag:

Thanks, I'll check it out when it's updated. Perhaps the issue is fully gone then. The changes I have on my end seem to almost fix the problem so far.
Squee  [developer] Jun 6, 2018 @ 11:39am 
I have checked and updated all my wallpapers by now .. Went quick as most were setup the same.

If there are any other issues, just let me know ..
Last edited by Squee; Jun 6, 2018 @ 11:44am
< >
Showing 1-5 of 5 comments
Per page: 1530 50