I imagine this is already known, but just incase and just for record keeping, after completing the focuses "Reform the scientists" and "Reform the officers" the advisors remain purist advisors despite what the focus says it did.

also I'm unsure if this is intentional or not, but for some reason reformed Anderson gives ruler support instead of intellectuals support

I found out why the "Reform the scientists" and "Reform the officers" wasn't adding the reformed advisors. They weren't "recruited" in the ERB history file in the mod. I added the recruit_character line for reformed Wilkins and Curling as well as their upgrades. I haven't tested if this will cause problems down the line but the advisors show up in the proper place now

Originally posted by Toma:

I found out why the "Reform the scientists" and "Reform the officers" wasn't adding the reformed advisors. They weren't "recruited" in the ERB history file in the mod. I added the recruit_character line for reformed Wilkins and Curling as well as their upgrades. I haven't tested if this will cause problems down the line but the advisors show up in the proper place now

I'll give it a try and see if it works out, I also plan on doing a long playthrough, so I'll end up seeing if any issues arise.

Originally posted by Toma:

I found out why the "Reform the scientists" and "Reform the officers" wasn't adding the reformed advisors. They weren't "recruited" in the ERB history file in the mod. I added the recruit_character line for reformed Wilkins and Curling as well as their upgrades. I haven't tested if this will cause problems down the line but the advisors show up in the proper place now

one immediate issue is that now you have both versions if you just add them as recruited, though this may just be because of me doing focus auto complete and no checks, but it does add them now though

edit 1: also I feel like at least part of the issue might be that the focus code tries to add and remove ideas, I get the feeling that's not how you add/remove advisors

edit 2: nvm, I just looked up effects, adding/removing "ideas" is how you're supposed to do it, I have zero clue what's going on anymore lmao

edit 3: the swap_ideas effect is seemingly incorrectly written for the advisors despite being correctly written else where within the same focus for the national spirits.

@The US Doctor

About the Purist advisors not changing to Reformer, I already changed the code and I'm preparing to launch a new patch, about Anderson's Ruler support, it's intentional (since the ruler is the Iron President path, which I'm almost sure Anderson would support).

Originally posted by EduuP:

@The US Doctor

About the Purist advisors not changing to Reformer, I already changed the code and I'm preparing to launch a new patch, about Anderson's Ruler support, it's intentional (since the ruler is the Iron President path, which I'm almost sure Anderson would support).

y'know what, that makes sense, sorry if I was being a pest lol. what ended up being the actual solution if I can ask?

Originally posted by The US Doctor:

Originally posted by EduuP:

@The US Doctor

About the Purist advisors not changing to Reformer, I already changed the code and I'm preparing to launch a new patch, about Anderson's Ruler support, it's intentional (since the ruler is the Iron President path, which I'm almost sure Anderson would support).

y'know what, that makes sense, sorry if I was being a pest lol. what ended up being the actual solution if I can ask?

No problem, and you haven't been a pest lol. The actual solution was the events, because they are the ones who actually Reform the Scientists, and you have to wait like 150 days before they get Reformed.

Huh I see

There is bug on The Red, White and the Blue Banners focus (enc_electoral_victory_usa), it says invalid event id enc_reformers.23500, i checked the file there is no event with that id but enc_reformers.235

Originally posted by Overlord:

There is bug on The Red, White and the Blue Banners focus (enc_electoral_victory_usa), it says invalid event id enc_reformers.23500, i checked the file there is no event with that id but enc_reformers.235

It's because I didn't created the event in which the NCR is annexed to the Enclave, it will be fixed in the next patch that MIGHT release in the next few days.

Originally posted by The US Doctor:

Originally posted by Toma:

I found out why the "Reform the scientists" and "Reform the officers" wasn't adding the reformed advisors. They weren't "recruited" in the ERB history file in the mod. I added the recruit_character line for reformed Wilkins and Curling as well as their upgrades. I haven't tested if this will cause problems down the line but the advisors show up in the proper place now

one immediate issue is that now you have both versions if you just add them as recruited, though this may just be because of me doing focus auto complete and no checks, but it does add them now though

edit 1: also I feel like at least part of the issue might be that the focus code tries to add and remove ideas, I get the feeling that's not how you add/remove advisors

edit 2: nvm, I just looked up effects, adding/removing "ideas" is how you're supposed to do it, I have zero clue what's going on anymore lmao

edit 3: the swap_ideas effect is seemingly incorrectly written for the advisors despite being correctly written else where within the same focus for the national spirits.

I fixed the 1st issue by adding a parameter in the visible argument for the purist advisors so they are hidden when you take the focus. But seeing EduuP's fix seems better and a bit more balanced.

@Toma Would you like to descript how to fix bug with Curling and Wilkins in more detail, please?

I went into the the ERB-Enclave.txt history file in this mod's folder and added the lines:

recruit_character = col_wilkins_reformed
recruit_character = col_wilkins_reformed_upgrade
recruit_character = benjamin_curling_reformed
recruit_character = benjamin_curling_reformed_upgrade

Then I changed col_wilkins and benjamin_curling in Steam\steamapps\workshop\content\394360\3436501066\common\characters\ERB.txt to have the added parameter
NOT = {has_completed_focus = enc_reachout_officers} and
NOT = {has_completed_focus = enc_reachout_scientists} respectively

As far as I can tell it has worked both using debug at the beginning of the game and running through it normally

im such not smart with that but i will try my best to follow those paths u are talking about haha