Crusader Kings III

Crusader Kings III

Dark Ages
TheLoneWanderer 13. dec. 2024 kl. 19:05
Error Log
I have over a million of the errors below. Are these because of mod conflicts or something to do with the mod? Thx

[jomini_script_system.cpp:284]: Script system error!
Error: has_trait trigger [ trait was null ]
Script location: file: common/on_action/darkages_on_actions.txt line: 639 (darkages_more_illnesses_on_action:trigger)

[jomini_script_system.cpp:284]: Script system error!
Error: has_trait trigger [ trait was null ]
Script location: file: common/on_action/darkages_on_actions.txt line: 640 (darkages_more_illnesses_on_action:trigger)
< >
Viser 1-15 af 19 kommentarer
TheLoneWanderer 13. dec. 2024 kl. 19:10 
And about 520,000 of the errors below


Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 192 (darkages_add_shrewd_dull.03:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 193 (darkages_add_shrewd_dull.03:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 30 (darkages_add_shrewd_dull.01:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 267 (darkages_add_shrewd_dull.04:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 268 (darkages_add_shrewd_dull.04:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 272 (darkages_add_shrewd_dull.04:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 105 (darkages_add_shrewd_dull.02:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 273 (darkages_add_shrewd_dull.04:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)

Error: has_trait trigger [ trait was null ]
Script location: file: events/darkages_add_shrewd_dull.txt line: 106 (darkages_add_shrewd_dull.02:trigger)
file: common/on_action/darkages_on_actions.txt line: 490 (da_add_not_genetic_traits)
Cardolam  [udvikler] 17. dec. 2024 kl. 3:24 
Hi,

Dark Ages tests some traits that are not from vanilla but from other mods to increase compatibility. Those reported errors are absolutely harmless.

Thank you for the report!
TheLoneWanderer 19. dec. 2024 kl. 13:08 
Hi Cardolam, these messages do create massive error.log files that I suspect create lag as they grow and crash the game after a few hours of play. I could be mistaken
Cardolam  [udvikler] 19. dec. 2024 kl. 15:30 
The error log is generated at game start, not dynamically built along gameplay. Again, the issue in question is well understood and explained. CK3.exe tries to find the non defined traits - only if you run also all the specific mods would the issues disappear - and generates errors. But that doesn't mean there are any side effects to adding these traits.

I thank you for your concern and the constructive post but this has nothing to do with CTDs. At this point, I'd say there is not a single induced CTD coming from Dark Ages.
TheLoneWanderer 19. dec. 2024 kl. 15:34 
@Cardolam.... the errors seem to be dynamic as there are 100s of thousands of them with time stamps that indicate they are occurring over time. I am not trying to debate, but they are constant throughout my game.
Cardolam  [udvikler] 20. dec. 2024 kl. 2:53 
Yes, looking better in error.log you are right, it is built dynamically.
I have implemented undefined traits since 2021 for the mod to be compatible with "Trick or Trait" and no problems came from that implementation since then.
TheLoneWanderer 20. dec. 2024 kl. 11:38 
It's specifically the lines below in darkages_on_actions.txt that are causing the messages.

When I commented all of them out, the game crashed before starting...so I exceeded my quite limited modding capabilities, LOL. Commenting out the 1st two lines reduced the messages and did not crash the game though

----------------------------------------------------------------------------------------------------------------

# NOT = { has_trait = return_to_hell } #To make DA compatible with Sappho's Daughter.
# NOT = { has_trait = dragon } #To make DA compatible with AGOT.


da_add_not_genetic_traits = { #MOVE THEM TO BIRTH EVENTS? - TO DO

random_events = {

388 = 0
2 = darkages_add_shrewd_dull.01 #SHREWD
2 = darkages_add_shrewd_dull.02 #DULL
2 = darkages_add_shrewd_dull.03 #STRONG
2 = darkages_add_shrewd_dull.04 #WEAK
2 = darkages_loyal_disloyal.01 #LOYAL
2 = darkages_loyal_disloyal.02 #DISLOYAL
----------------------------------------------------------------------------------------------------------------
TheLoneWanderer 20. dec. 2024 kl. 11:47 
is the coding for the random events also for mod compatibility?

The error is "trait was null" which occurs for every line and every trait. This leads me to ponder if these 9 lines of code are doing anything / functioning as intended. However, I acknowledge that my coding skills are rudimentary.
TheLoneWanderer 20. dec. 2024 kl. 11:59 
*Update* - After your most recent update, I unsub'd and resub'd the mod. Then I loaded a saved game and just commenting out those two lines crashed the game. Undoing what I had done by removing the # that I added to those two line fixed the crash that I created.

--the end of my effort to address the error message.. ignominious defeat
Cardolam  [udvikler] 20. dec. 2024 kl. 15:09 
On actions are particularly sensitive ♥♥♥♥♥♥♥, that is what I can say. I am sure if you comment those two lines and start a new game everything will run fine. However, from that point on you need to comment those two lines for every update I deliver.

Regarding the da_add_not_genetic_traits on action the first four events called have triggers that test, once again undefined traits, unless you are playing with the mod "Trick or Trait".
TheLoneWanderer 20. dec. 2024 kl. 16:19 
@Cardolam - the only reason I was tinkering with it was to see if I could reduce the error message.. like you mentioned it has no game impact, it just creates a huge error.log file with many millions of lines of messages--- at least for me, which could be issues with other mods.
Cardolam  [udvikler] 21. dec. 2024 kl. 4:52 
I have an idea to solve the issue, will define the traits within Dark Ages by copying from the other mods. So, next week you will not have anything to worry about.
Sidst redigeret af Cardolam; 21. dec. 2024 kl. 4:52
TheLoneWanderer 21. dec. 2024 kl. 5:59 
excellent news! Thank you
LVLVbNH 30. dec. 2024 kl. 0:16 
Looks like trait `blademaster_1` should be replaced to `lifestyle_blademaster` in file
common\decisions\darkages_decisions.txt
[E][jomini_script_system.cpp:284]: Script system error! Error: has_trait trigger [ Cannot find blademaster_1 in trait database ] Script location: file: common/decisions/darkages_decisions.txt line: 98 (darkages_train_combat_decision:effect) [E][jomini_script_system.cpp:284]: Script system error! Error: has_trait trigger [ Cannot find blademaster_2 in trait database ] Script location: file: common/decisions/darkages_decisions.txt line: 99 (darkages_train_combat_decision:effect) [E][jomini_script_system.cpp:284]: Script system error! Error: has_trait trigger [ Cannot find blademaster_3 in trait database ] Script location: file: common/decisions/darkages_decisions.txt line: 100 (darkages_train_combat_decision:effect)
Sidst redigeret af LVLVbNH; 30. dec. 2024 kl. 0:16
LVLVbNH 30. dec. 2024 kl. 0:36 
Same file - common\decisions\darkages_decisions.txt. is_shown for event `darkages_plan_border_raid` defined twice
[E][pdx_persistent_reader.cpp:216]: Error: "Trigger section already read earlier: is_shown, near line: 2422" in file: "common/decisions/darkages_decisions.txt" near line: 2440
< >
Viser 1-15 af 19 kommentarer
Per side: 1530 50