RimWorld
TD Enhancement Pack
Uuugggg  [ontwikkelaar] 30 mrt 2018 om 2:25
Bug Reports
Let's keep the comments clean, report bugs here!

=========================
When submitting bugs
1) post debug log
2) be specific
3) don't be vague
4) post debug log
5) maybe explain why you think this mod is causing the problem

( I am honestly going to ignore things if I don't get these )
=========================

Vague reports can only get the response " well, that doesn't happen here "

---

The game produces log files. These are essential for debugging.

Get HugsLib, press ctrl-F12 to upload logs.
Laatst bewerkt door Uuugggg; 29 feb 2020 om 13:23
< >
61-75 van 122 reacties weergegeven
Uuugggg  [ontwikkelaar] 12 jan 2021 om 9:33 
1. So. Uh. It's been a while since I made it, so who knows how good my memory is, but why do you think this mod borrows code from the WallLight mod? O_o

2. Can verify it's this mod with a new game

3. This seems to me that some other mod references WallLight, but doesn't handle it missing. What other mod - can't tell
Exception ticking world pawn Yuuta. Suppressing further errors. System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.ThrowHelper.ThrowInvalidOperationException (System.ExceptionResource resource) [0x0000b] in <567df3e0919241ba98db88bec4c6696f>:0
at System.Collections.Generic.List`1+Enumerator[T].MoveNextRare () [0x00013] in <567df3e0919241ba98db88bec4c6696f>:0
at System.Collections.Generic.List`1+Enumerator[T].MoveNext () [0x0004a] in <567df3e0919241ba98db88bec4c6696f>:0
at System.Linq.Enumerable.TryGetFirst[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate, System.Boolean& found) [0x0004f] in <351e49e2a5bf4fd6beabb458ce2255f3>:0
at System.Linq.Enumerable.FirstOrDefault[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) [0x00000] in <351e49e2a5bf4fd6beabb458ce2255f3>:0
at TD_Enhancement_Pack.Learn_Patch.Postfix (RimWorld.SkillRecord __instance, System.Single xp) [0x00036] in <c5f8a9e4c44b499ca78ae23841a65df9>:0
at (wrapper dynamic-method) RimWorld.SkillRecord.RimWorld.SkillRecord.Learn_Patch2(RimWorld.SkillRecord,single,bool)
at (wrapper dynamic-method) RimWorld.SkillRecord.RimWorld.SkillRecord.Interval_Patch1(RimWorld.SkillRecord)
at RimWorld.Pawn_SkillTracker.SkillsTick () [0x0008f] in <c36f9493c9844ddaa7fb5c788416098f>:0
at (wrapper dynamic-method) Verse.Pawn.Verse.Pawn.Tick_Patch3(Verse.Pawn)
at RimThreaded.RimThreaded.ExecuteTicks () [0x00562] in <0159967a552640fa8217f400cfa096c6>:0
Verse.Log:Error(String, Boolean)
Verse.Log:ErrorOnce(String, Int32, Boolean)
RimThreaded.RimThreaded:ExecuteTicks()
RimThreaded.RimThreaded:ProcessTicks(ThreadInfo)
RimThreaded.RimThreaded:InitializeThread(ThreadInfo)
RimThreaded.<>c__DisplayClass80_0:<CreateWorkerThread>b__0()
System.Threading.ThreadHelper:ThreadStart_Context(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object)
System.Threading.ThreadHelper:ThreadStart()


Eventually it cuases the pawns to stop working.

Removing TD Enhancement fixes the problem.
Uuugggg  [ontwikkelaar] 14 feb 2021 om 23:07 
#1 I'd imagine removing RimThreaded would fix the problem, too.

#2 Disable the setting for, like, 'skill arrow when learning arrow' or whatever that is called

Hey @Uuugggg not sure if I'm right or barking at the wrong tree.
While going through Dubs Analyzer Harmony Patches i can see that this gets called when unpaused i presume for every sowable cell a check is made even without harvest toggle being on. Shows as TD_Enchancement_Pack.NoHarvestJob:Prefix

[HarmonyPatch(typeof(WorkGiver_GrowerHarvest), "HasJobOnCell")] //Tried ExtraRequirements and it was inconsistent?
public static class NoHarvestJob
{
//public override bool HasJobOnCell(Pawn pawn, IntVec3 c)
public static bool Prefix(Pawn pawn, IntVec3 c, ref bool __result)
{
if(pawn.Map.zoneManager.ZoneAt(c) is Zone_Growing zone
&& !zone.CanHarvest())
{
__result = false;
return false;
}
return true;
}
}
Can you work some Voodoo magic and skip code related to this functionality if Allow Harvest toggle is off ? Other than this,
Thank for a great QoL mod.
Laatst bewerkt door Raskaran; 4 mrt 2021 om 18:10
Uuugggg  [ontwikkelaar] 4 mrt 2021 om 21:08 
That'll go on the list of easy little things to do.
I'm running into an issue that is happening commonly when a zone is ready to have some plants harvested and there is either hunting or some form of combat occurring at the same time.

Log message is:

System.NullReferenceException: Object reference not set to an instance of an object
at RimWorld.BroadshieldPack.Notify_BulletImpactNearby (RimWorld.BulletImpactData impactData) [0x0000e] in <5bed3a4a3d4545d78cb9bae12001e2b7>:0
at RimWorld.Bullet.NotifyImpact (Verse.Thing hitThing, Verse.Map map, Verse.IntVec3 position) [0x00074] in <5bed3a4a3d4545d78cb9bae12001e2b7>:0
at RimWorld.Bullet.Impact (Verse.Thing hitThing) [0x0004a] in <5bed3a4a3d4545d78cb9bae12001e2b7>:0
at Verse.Projectile.ImpactSomething () [0x00329] in <5bed3a4a3d4545d78cb9bae12001e2b7>:0
at Verse.Projectile.Tick () [0x000ed] in <5bed3a4a3d4545d78cb9bae12001e2b7>:0
at (wrapper dynamic-method) Verse.TickList.Verse.TickList.Tick_Patch2(Verse.TickList)

A new version of Harmony also gives additional debugging info into which mod patches were involved in the stack trace. This is identifying that when the error is thrown the game is inside the TD Enhancement pack's "static TickGrow_PlantHarvest.Postfix (TickerType __tickType)" function, as seen in the screenshot at:
https://steamuserimages-a.akamaihd.net/ugc/1756946498860261394/F5221AFC824DB0EE163C0E767E6AEEEB9467871A/

When this happens, it causes significant lag until either the combat stops and/or the items to be harvested have been harvested (adding up to thousands of instances during the course of a combat - I've captured the screenshot after a very short hunt, but I've seen 6000+ instances reported after an invasion previously).
Uuugggg  [ontwikkelaar] 27 mei 2021 om 21:51 
Well. TL;DR Not me.

Harmony knows that I postfix-patch the Tick method (TickList.Tick_Patch2) - so it may be reporting TD Pack's involvement with the stacktrace. But That's not saying it's *in* my method. That's uh, that's what the stacktrace is. No mods in there, but geez who knows what modded items are confusing things somewhere in there.

The TD patch is sort of just adjacent and uninvolved. And, the TickGrow_PlantHarvest.Postfix is a tiny tiny method that does almost nothing anywho.
@Dawnmist, Take a look at the mod "Suppression"
@velcroboy333 - I don't currently use the mod Suppression, and reading its description I can't see why I would want to add it myself. If you were suggesting it as a possibility for causing the issue it's not installed.
@Uuugggg - no modded weapons or armours, only combat related mods are Simple Sidearms and Achtung, neither of which should affect projectile impacts and neither of which affect the actual weapons themselves. It also only happens when there are plants in a grow zone that are ready to harvest, which was why I thought that the harmony report of it happening within the patched tick may have been relevant.

I'll continue to just ignore it.
Hmm, yeah I wad implying that Suppression was the source of this error as I had a similar issue with the error you are getting and tps of <10 during combat. But if you're not using that mod...
Laatst bewerkt door velcroboy333; 28 mei 2021 om 7:17
Hello. Getting a few errors related to this mod. Any help would be appreciated!
Log: https://gist.github.com/831b35b172015d05570a1ee664ea926d
Uuugggg  [ontwikkelaar] 10 jun 2021 om 19:41 
I dunno where you got your TD Pack from but it's missing files and for some reason is named "Anonymous189.TDHEnhancementPack"

TD EnhancementPack(Anonymous189.TDHEnhancementPack): (no assemblies)
https://gist.github.com/HugsLibRecordKeeper/09e4445a5bf1a131a9d6090d83eb86e1
Error in static constructor of TD_Enhancement_Pack.DoNotHarvest_Building: System.TypeInitializationException: The type initializer for 'TD_Enhancement_Pack.DoNotHarvest_Building' threw an exception. ---> System.ArgumentException: An item with the same key has already been added. Key: Uuugggg.rimworld.TD_Enhancement_Pack.main at System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x000c1] in <eae584ce26bc40229c1b1aa476bfa589>:0 at System.Collections.Generic.Dictionary`2[TKey,TValue].Add (TKey key, TValue value) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 at Analyzer.Profiling.StackTraceUtility.RegisterHarmonyId (System.String harmonyid, System.Reflection.Assembly assembly) [0x00000] in <a7582379f01c4469bece9ddc85ee3af2>:0 at Analyzer.Profiling.RememberHarmonyIDs.Prefix (System.String id) [0x00074] in <a7582379f01c4469bece9ddc85ee3af2>:0 at (wrapper dynamic-method) HarmonyLib.Harmony.HarmonyLib.Harmony..ctor_Patch1(HarmonyLib.Harmony,string) at TD_Enhancement_Pack.DoNotHarvest_Building..cctor () [0x00016] in <f3d9394f19614afdbb224af1f4d5d58b>:0 --- End of inner exception stack trace --- at (wrapper managed-to-native) System.Runtime.CompilerServices.RuntimeHelpers.RunClassConstructor(intptr) at System.Runtime.CompilerServices.RuntimeHelpers.RunClassConstructor (System.RuntimeTypeHandle type) [0x0002a] in <eae584ce26bc40229c1b1aa476bfa589>:0 at (wrapper dynamic-method) Verse.StaticConstructorOnStartupUtility.Verse.StaticConstructorOnStartupUtility.CallAll_Patch2() UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch3 (string) (wrapper dynamic-method) Verse.StaticConstructorOnStartupUtility:Verse.StaticConstructorOnStartupUtility.CallAll_Patch2 () Verse.PlayDataLoader/<>c:<DoPlayLoad>b__4_3 () Verse.LongEventHandler:ExecuteToExecuteWhenFinished () Verse.LongEventHandler:UpdateCurrentAsynchronousEvent () Verse.LongEventHandler:LongEventsUpdate (bool&) (wrapper dynamic-method) Verse.Root:Verse.Root.Update_Patch1 (Verse.Root) Verse.Root_Entry:Update ()

Same error with Smart Medicine, posted it over there too.
This mod is causing lag for me. Performance analyzer identifies it coming from "Learned Game Component" from the assembly TD Enhancement Pack; .Settings:Get in particular.

Here's my log if it matters:
https://gist.github.com/55bf2501fc6978d6fc74834e4b53a6a7

Screenshot of the analyzer if it helps:
https://imgur.com/a/GTTvdMm
< >
61-75 van 122 reacties weergegeven
Per pagina: 1530 50