Thats fixed the issue, thank you

I have pushed an update that should fix it.
It now doesn't show faction goodwill if target faction is Player.

log*

Window just does not pop up when you try to trade with your own sity, vanila works perfectly fine tho. Sity has the same faction so you are trading with yourself ig. Heres link [gist.github.com] to that issue

@Bogatir
I do not understand what the incompatibility is, or the issue at hand.
The goodwill calculation uses the same vanilla function in the same way as the default trade window.
I assume that if RIMMSqol has a situation in which you are trading with yourself, then they have patched the vanilla trade window to support that?

found an compactability issue with RIMMSqol sitys. Thats what author of RIMMSqol said:
The mod tries to calculate the goodwill with the player faction from the trader faction. However they fail to safeguard that call against trade with the player faction itself.

No worries, it happens. :)
Thanks for the super quick fix, it's working again now!

It should now be fixed, however steam does not like updating multiple times in a day, so you may need to resubscribe.

And as a reminder, all previous versions are available from the link in the description!

I have found the issue. I am very sorry about the inconvenience.
Turns out there was a previous typo in a file that caused it to load the 1.6 assembly in 1.5.
And i even double checked this multiple times.

The fix should be up in a moment

With today fix it's not working anymore with 1.5 :( I'm getting the default trading window.

Thanks so much for the quick fix! :D

Thanks for letting me know, it is now fixed (oops!)
Funny difference between trading and gifting: the direction inverses.

Very minor bug report here: in the gift interface, the "gift none" and "gift all" tooltips are swapped.

Thanks for the awesome mod!

Appreciate the heads up. I will see if i can figure out a solution.

Found the culprit, thanks for the hint. :) Enabling/disabling "texture compression" from graphic settings didn't make any difference, I tried to remove Graphic Settings + (https://steamcommunity.com/sharedfiles/filedetails/?id=1678847247) and the icons are back. I tried one more time to adding the mod back and icons are gone again. There seem to be a compatibility with that mod.

@ajejebrazorf
Looks like your issue is different, and i don't see any errors in your log directly related to DynamicTrade.
However, there is a series of texture loading errors earlier in the log:
"d3d11: failed to create 2D texture id=1889 width=30 height=30 mips=6 dxgifmt=28"
30x30 fits with the size of the icons i use.
I do not know what could be causing this however, and will need to investigate further. Most likely it's an issue on the machine.

Have you done texture conversions? and if so, have you updated it to include any potentially new icons? Perhaps GPU drivers?

Hi, I'm facing the same issue reported by leosefcik about missing icons. https://gist.github.com/HugsLibRecordKeeper/a6c825ebb5350f59d631ac1c3bda920e
You can find Rimsort mod list and save file, hope they help troublehoshooting the issue: https://drive.google.com/drive/folders/1Rm30FxwVPLF2KL9BInWL6sPxi7iXv_9r

@DemonsxHunter
AdaChanDesu asked both Ferny and I about this, and i reworked the icons system entirely to allow others to easily add integration.

Can you add patch to Progression: Agriculture, so we can know what seeds we own?
https://steamcommunity.com/sharedfiles/filedetails/?id=3418017359

@Zeracronius Ahh so I take it it's a Niilo's Quality of Life error? I'll bring it up to them as well, thank you

NQualityOfLife is Niilo's QoL, and it's erroring in "NQoL_DropSpot_Patch"

@yasosume
That does not seem to be related to the update. In this case you are clicking confirm, and then NQualityOfLife intercepts the trade and subsequently throws an error.

Hey there, after the update I seem to have lost the ability to trade. After hitting accept, the buttons disappear and their goods disappear. Here's a log and screen shot
https://gist.github.com/HugsLibRecordKeeper/a195c10117170a35475906a5150cdf3b
https://imgur.com/a/3aGvYcO

I have pushed an update that should hopefully fix it.

Yeah, could be related because I don't own Ideology, its not that much of an issue for me tho since i can see the tooltips when i hover over them. Thanks for the cool mod

@leosefcik
I have had a few reports of the icons missing, but been unable to track it down.
Based on your log, however, i may have identified the issue being related to slaves and ideology. There's a lot of entries in the log related to missing Slavery icon.

I haven't had these issues myself, but i'll be looking into it.

Nvm, for some reason the white buttons at the top of the window are invisible for me. Here's a report and screenshot if it helps:
https://gist.github.com/HugsLibRecordKeeper/53f92f2c20df08bf278f5f08f8783f98
https://imgur.com/a/xIWWw8p

"- Togglable and resizable summary section similar to TradeHelper."
Hello, sorry if im just super dumb but where do i toggle this? From my understanding, you can make it look like the 1st screenshot, but i cant find the option anywhere

@EPrime
I think you are lacking an update, i can't reproduce the issue on my end, and all the XML and code looks fine as far as i can tell.
Issues with gene icons was what turol reported, and that got fixed.

I should have the latest bits, but get an error for GenepackDrawable:GetSearchString (GenepackIconDef column) (otherwise same as for tech print below)

Thank you for keep this updated - it's the best trade interface! :)

Pushed a fix.

Darn, seems the merge issue leading to gene icons breaking affected more files than I thought.
Thanks for letting me know, I will have it fixed as soon as I can.

I think the last update to Dynamic Trade Interface broke compatibility with Show Known Techprints .

Error:
[Dynamic Trade Interface] Unable to locate draw callback 'DynamicTradeInterface.UserInterface.Columns.ColumnExtraIconTypes.TechprintDrawable:GetIcons' for IconDef TechprintIconDef.
Ensure referenced method has arguments matching 'Tradeable' and a return type of 'IEnumerable<(Texture, string?, Color?)>'

@Zeracronius Confirm fixed. Thanks for the quick response.

Turned out that it was caused by a typo. Last update included a major refactoring to allow other mods to add additional icons.
It should be fixed now.

Probably, i'll look into it!

I think the last update broke the trade window icons from "Random's gene assistant". There should be a little colored icon next to the item name indicating if you have the genes in your bank. Now it's gone.

@AdaChanDesu
Asking is perfectly fine, the rude part is if people start demanding.

I am not familiar with that mod, I can look into it, but it may be simplest if they did it on their side.
It would most likely be the code they already have, just running in a harmony patch on the More Icons method.

Hello there, knowing the possibility of sounding like an obnoxious ass, could you possibly look into compatibility with Progression: Agriculture? It adds icons to the trade menu that show whether you've already unlocked a seed bundle that traders have available for sale. I've looked into the source code of both mods and unfortunately my Intellectual skill isn't high enough to do this kind of patching yet (gotta learn that soon as asking modders for anything just seems like a rude thing to do)

@月空
What text won't appear?
Remember that columns are resizable by dragging the edges of the header, if you have some text getting cut off.

When the game interface is set to 1.25x zoom, the text will not appear

I doubt I'll manage to find anything but I'll be sure to let you know if I do.

I am not familiar with any conflicts or load order issues, so i'm unfortunately not much help on that. But if you figure it out do let me know!

Thank you for the response. I had no icons at the top of the main trade window, so I tried disabling all other mods. Since the buttons are now present, I suspect a mod conflict or mod list ordering issue. Do you have any advice regarding mod list order or troubleshooting to find the culprit?

@Nathan
The button to show and hide the trade summary is in the top right corner on the main window, directly to the right of the lock.

The profiling option is entirely to measure the impact of individual shown columns. Since other mods can add additional columns, it could be useful to track down if there is a sudden noticable hit in performance.

I can definitely look into doing alternating row colors.

I like the trade UI provided by this mod but I do have three questions if that's okay.

1: I can't seem to locate the option to enable the trade summary section. Where might I find it?
2: What is "Enable Profiling" in the mod options?
3: Is there any chance for the addition of the option to have color banding/alternating row colors for items?

Thank you for the mod and your continued work on it!

That is indeed the case

This is probably a dumb question, but from the description it sounds like this is actually more performance friendly than vanilla. Is that correct?

Glad to hear you figured it out!
Hopefully the author can provide a fix.

I found the culprit: "Bizarre Foods On Caravan" messed with book tooltips. But now I lost the informations provided by this mod ^^'
Thank you for the schematic icon!