RimWorld

RimWorld

DBH & VFEC/Hot Spring Compatibility
83 Comments
Scorpio Apr 13 @ 5:29am 
@Jeremy Lin allies are helpful is a buggy mess with save breaking bugs like the pawn duplication glitch on save load
NightmareCorporation  [author] Apr 13 @ 3:02am 
I added a safety-catch to that particular patch, so that even if this mod was the culprit (which I doubt after having read its code again), it would not provoke any deeper issues except for possibly logging an error every tick.
NightmareCorporation  [author] Apr 12 @ 12:13pm 
@Jeremy Lin
That doesn't show the full exception. But yea, either Rocketman, AlliesAreHelpful, VisiblePants, DualWield, YayosCombat3 or this mod are responsible for that exception. If you provide a full exception callstack or even better a hugslog, I can analyze further.
Jeremy Lin Apr 12 @ 12:46am 
haven't build the hotspring but got a error
Jeremy Lin Apr 12 @ 12:46am 
[Ref 33FB6539]
at PawnTendAndRescuePatch.Postfix (Verse.Pawn __instance) [0x00292] in <cee733ba90ed47bfb290c3365752ff89>:0
at Verse.Pawn.Tick () [0x00600] in <630e2863bc9a4a3493f2eff01e3a9556>:0
- TRANSPILER Krkr.RocketMan.Soyuz: IEnumerable`1 Soyuz.Patches.Pawn_Tick_Patch:Transpiler(IEnumerable`1 instructions, ILGenerator generator)
- POSTFIX alt4s.alliesarehelpful: Void PawnTendAndRescuePatch:Postfix(Pawn __instance)
- POSTFIX DBH_Hotspring_Compatibility: Void DBH_Hotspring_Compatibility.Patch_Pawn:AddHygieneForBathingPawns(Pawn __instance)
- POSTFIX XeoNovaDan.VisiblePants: Void VisiblePants.Patch_Pawn+Patch_Tick:Postfix(Pawn __instance)
- POSTFIX Roolo.DualWield: Void DualWield.HarmonyInstance.Pawn_Tick:Postfix(Pawn __instance)
- POSTFIX Mlie.YayosCombat3: Void yayoCombat.HarmonyPatches.Pawn_TickRare:Postfix(Pawn __instance)
- FINALIZER Krkr.RocketMan.Soyuz: Void Soyuz.Patches.Pawn_Tick_Patch:Finalizer(Pawn __instance, Exception __exception
月下冬萤 Apr 5 @ 9:50am 
thank you!
NightmareCorporation  [author] Apr 5 @ 9:37am 
@月下冬萤
Rockery? You mean the nice looking one with the elaborate rocks? That's the one from Kijin,
月下冬萤 Apr 5 @ 7:49am 
Excuse me, which mod is the hot spring with rockery?
NightmareCorporation  [author] Sep 2, 2024 @ 12:22am 
@Reily
No known incompatibilities or issues with startup

I need a log to analyze your issue. You can use this mod:
https://steamcommunity.com/sharedfiles/filedetails/?id=2873415404

Reproduce your issue and then press CTRL + F12. If you are unable to upload the log through the in-game mod, use the button for more details and copy it to clipboard, then manually upload it to a website like https://pastebin.com/
Reily Sep 1, 2024 @ 11:20pm 
Are there any known incompatibilities? This mod causes the game to crash during start-up for me
MORROGANDER Aug 7, 2024 @ 11:17pm 
thanks for reply, i will propose it to ReGrowth
NightmareCorporation  [author] Aug 7, 2024 @ 11:15pm 
@MORROGANDER
I suggest proposing the feature to ReGrowth Core in that case. This compatibility patch does not make pawns try to increase their hygiene in hot springs.

I will add extra information to the description because the question has popped up in the past and I answered as such:

> This mod does not change anything about bathing behavior.
What it adds is pawns regenerating hygiene as a side-effect of bathing, pawns should not go into a hot spring with the intent of cleaning themselves.

(Just like in real life, if you go into a communal hot spring just to clean yourself - that's very icky :) )
MORROGANDER Aug 7, 2024 @ 7:39pm 
Pawns seem to only take a bath in ReGrowth Boiling Hot Spring as a recreation tho,
They will not actively seek to clean themselves with Boiling Hot Spring when they are dirty.
MORROGANDER Aug 7, 2024 @ 9:02am 
Me, also shamelessly asking for support to the mod Spartan asked for, please :c
tsuyashu Aug 3, 2024 @ 8:33am 
I also shamelessly asking for support to the mod Spartan asked for, please :c
SP4RTAN Jul 31, 2024 @ 10:24am 
turkler Jul 21, 2024 @ 12:21pm 
thank you for the update!
lloki May 27, 2024 @ 8:25am 
@NightmareCorporation now undressing is working, thanks!
NightmareCorporation  [author] May 25, 2024 @ 9:12am 
@Zaljerem
Done. May I recommend that you publish your small hot spring code via git? Would have saved me some time with digging the correct toil information to patch into.
Zaljerem May 25, 2024 @ 5:28am 
Excellent! I'll link back of course. Thank you!
NightmareCorporation  [author] May 25, 2024 @ 5:18am 
@Zaljerem
Sure thing, will do and link accordingly.
Zaljerem May 25, 2024 @ 5:09am 
Hi, I don't suppose you'd care to add DBH support to this? You'd save me some work as I don't really use DBH, and you seem to know what needs to be done. Thanks for your consideration. https://steamcommunity.com/sharedfiles/filedetails/?id=3171013935
NightmareCorporation  [author] May 25, 2024 @ 3:24am 
@lloki @a quality meme
Yea, that was an issue due to the pawn render caching in 1.5. I have fixed it in the latest release.
a quality meme May 18, 2024 @ 8:41pm 
Yeah I tested it over and over. The thermal bath patch that has pawns undress for the bath simply doesn't work.
Zajian Apr 11, 2024 @ 2:03pm 
@NightmareCorporation thank you! I appreciate all the work you modders are doing for the community
lloki Apr 11, 2024 @ 1:13pm 
In my case they are not undressing in VFE:C Thermal Bath :(
Futstub Apr 11, 2024 @ 2:40am 
Neat mod. :>
NightmareCorporation  [author] Apr 11, 2024 @ 1:21am 
@Zajian
I just added support for 1.5 based on the unstable build and updated mods.
Zajian Apr 10, 2024 @ 1:54pm 
I dont see this asked here yet, but any chance on this being brought to 1.5 once it drops?
Genaeve Apr 1, 2024 @ 11:47pm 
OMG I've been looking for this for so long, I can't thank you enough! And it looks like I just wasn't looking in the right place!
Again, I can't thank you enough.
NightmareCorporation  [author] Mar 10, 2024 @ 12:34pm 
This mod does not change anything about bathing behavior.
What it adds is pawns regenerating hygiene as a side-effect of bathing, pawns should not go into a hot spring with the intent of cleaning themselves.

(Just like in real life, if you go into a communal hot spring just to clean yourself - that's very icky :) )
Dracon Mar 10, 2024 @ 9:17am 
Mine occasionally go there, but seem to still prefer the wash basis. That being said, when they go there, they only do it for recreation.
Space_Lettuce_OG Mar 1, 2024 @ 10:29pm 
My pawns never go into the therme bath, ever. Is there something I could've done wrong, or is this a known bug?
NightmareCorporation  [author] Dec 16, 2023 @ 1:57pm 
@Morlund
I have removed the unnecessary assemblies, but can not reproduce your issue. I assume there is some mod conflict.
MercuryRiver Dec 16, 2023 @ 7:25am 
I don't know if you'd be interested in this, but I'd love a mod that's the opposite of this, where you can't enter the hotsprings if dirty. I like the idea of having to wash off first.
NightmareCorporation  [author] Dec 13, 2023 @ 12:09am 
@Morlund
I'll check those issues when I can.

The 1.3 folder does indeed have more files, but they should not be there - they may cause issues if people have a messy load order. I'll remove them in an update later.
Morlund Dec 12, 2023 @ 1:17am 
Quick look in the file folder for the mod shows that there are more assemblies in the 1.3 folder than the 1.4 one, and maybe the game simply doesn't read the file needed in 1.4?
Morlund Dec 12, 2023 @ 1:15am 
Hey there, I'm having a slight issue. Pawns are gaining hygiene need in the VFEC thermal bath as they should but they refuse to undress. No errors in the standard devmode log. I'm almost certain I don't have another mod that would touch the thermal bath so I can't imagine the cause.
NightmareCorporation  [author] Dec 8, 2023 @ 10:19am 
@彼岸花丛中的死之结界
The call-stack hints at explosions, specifically ExtraExplosionEffects being the culprit of the exception.

As you may expect, this mod has absolutely nothing to do with explosions, nor can I find a possible NRE in the AddHygieneForBathingPawns method that Visual Exceptions is pointing out.
彼岸花丛中的死之结界 Dec 8, 2023 @ 7:31am 
I'm not quite sure, but Visual Exceptions indicates that the error source is here

https://imgur.com/a/YOuapSG
NightmareCorporation  [author] Oct 16, 2023 @ 11:39am 
@遠去の遺忘
No. Too much effort for no good reason I'm afraid.
遠去の遺忘 Oct 16, 2023 @ 9:28am 
Can Hot Spring Compatibility be divided into men and women like hygiene?
NightmareCorporation  [author] Jul 15, 2023 @ 6:36am 
I should have been more clear. The exception would happen for pawns that have no "need tracker", and all Pawns should always have a need tracker, even if they have no needs. Unless the mod creator is doing horrifying things to their Pawn instances. Either way this mod should be perfectly exception-safe now.
Lord Zero Jul 15, 2023 @ 6:17am 
I can add to that, Under the filter tab with dubs hygiene I unchecked the needs there for the android types in hopes of fixing the problem thought I believe the androids still don't have needs whether that is on or not
NightmareCorporation  [author] Jul 14, 2023 @ 9:44pm 
There is another extremely unlikely edge case that may be in effect here, that being that a pawn has no needs at all . I will add handling for this case, but outside of that I'd have to say this mod is not responsible.
Lord Zero Jul 14, 2023 @ 3:30pm 
Here's how it show's up https://i.imgur.com/hVUvcVX.png
Lord Zero Jul 14, 2023 @ 3:14pm 
https://gist.github.com/HugsLibRecordKeeper/66fcb12f1d9381dc7af2561be17a0435 the androids are ID 897 and ID 685, this a bit before I shut them down
Lord Zero Jul 14, 2023 @ 3:04pm 
Sure, I was about to dismantle them for parts, gotta revive em again and I'll send the log your way
NightmareCorporation  [author] Jul 14, 2023 @ 1:35pm 
What you said made me consider that there may be unexpected behaviour due to trying to retrieve hygiene from a pawn that doesn't have it. I just checked the code and was luckily smart enough to exclude this edge case:

Need_Hygiene need_Hygiene = pawn.needs.TryGetNeed<Need_Hygiene>();
if(need_Hygiene == null)
{
return;
}


Meaning that if a pawn has no hygiene need, this mod does nothing and throws no errors. Would still be interested in seeing the exception in your log.