The last time I tried, I found that FNA didn’t support it.

can HDR rendering be made to ouput to true HDR when using a HDR compatible monitor?

Thanks u bro for that cool mod

Alright. My Discord username is @username_of_rex.

Hey Rex! I have dug through a lot of the code already, and I found a few spots / things I'd like to mess around with, but wanted to bounce some ideas off you.

Could you add me on steam or discord?

Would be easier to go back and forth about code there haha

thank you

@ubimauri I tried once, but it didn’t work. I don’t think FNA supports HDR output, though I read somewhere that they’re working on adding it (haven’t checked recently though).

@RA3236 Yeah unfortunately Terraria’s rendering code is quite CPU bound.

Can you make it so the HDR rendering doesn't get tone mapped? I have an HDR monitor

lowest settings makes my game stutter really badly, and i dont think i have any conflicting mods

Those who have this mod lagging on good hardware, check if you have Calamity Wrath of the Gods in your mod list. This mod is laggy crap, by disabling it I got a boost from ~35 fps to stable 60 on the ultra preset.

Hi, I have a Ryzen 5 3600 and a GTX 1660 SUPER on an Arch Linux system. I've noticed that my GPU utilisation is always <40% yet I have around 120FPS with this mod installed on a 165Hz display (using the High FPS Support mod as well), suggesting a CPU bottleneck. Using Feral gamemode boosts this to around 155FPS. Increasing the quality preset from Low lowers FPS but does not improve GPU utilisation, with noticeable stuttering.

Is this a limitation of the mod/game engine? I'm already using a 1920x1080p display.

@Confused Thank you! If you'd like, take a look at the GitHub repo: https://github.com/RandomComputerUser/FancyLighting . I will warn that the code isn't documented and is not the best organized.

@Loksi Yes, there are no issues if the Fancy Atmosphere setting and the Realistic Sky mod are both enabled. However, I wouldn't necessarily recommend doing that, since they both do some similar things.

Does the Fancy Atmosphere setting work with realistic sky mod? would it be bad to have both enabled or should i choose

Im not sure what happened but... The problem is now fixed ig?
Anyways
Good mod overall
20/10
I recommend

I also thought at first that it was something like that
But i tried disabling fancy atmosphere and all my other mods, however the problem is still there
Seems like the problem is on HDR rendering and full HDR rendering, both of these configurations break the game completely

I've used fancy lightning since it was recently added to the workshop, is one of my favorite mods when it comes to making the game prettier than ever
I'd appreciate if you found a way to fix this issue

(And i also noticed im not the only one reporting this glitch about the HDR rendering)

Hey - Love the mod, it looks great!

Id like to help a bit with the development if there is any room for me to do so, I have noticed a few areas that could benefit from some optimization and id like to better understand the games lighting a bit better (even if just to use locally, just like having something to play with)

Maybe an issue with mod compatibility. Does this still happen if you disable Fancy Atmosphere in the config?

What happened after the last update?
Now when activating HDR rendering i can only see the background
And when activating full HDR rendering my screen turns black

Is there a fix?

If you're asking about how full HDR rendering compares to basic HDR rendering, there is a performance different, but it's not as extreme. On my laptop, I get around 60 FPS on the high preset and 50 FPS on the ultra preset.

It would be possible to implement bloom without full HDR rendering, but I don't think it would look very good. What full HDR rendering does is extend the internal brightness range, so that, for example, a fully lit sheet of paper and a bright light are different in brightness, whereas without HDR rendering they would both have the same brightness (100% white). With bloom, we'd want the bright light to have a stronger blur around it than the sheet of paper, but without HDR rendering, there's no way to differentiate between the two, so they would both be blurred similarly by the bloom effect.

Yes, full HDR rendering has a much higher performance impact (around 3x I'd guess) than the basic preset.

another question, does full hdr rendering take (noticably) more performance than basic?

Is it possible to make it so you can have bloom without full hdr rendering?

Disable Fancy Atmosphere in the config.

On the latest build I am having issues with color accuracy, all of the colors of the sunlight and sky in general are overexposed and washed out. This did not occur on the previous build, no configuration changes have been made.

I don’t have any systems with an Nvidia GPU, so unfortunately I can’t test it myself. Maybe try verifying your game files? Something could be wrong with your game…

nvidia, always on latest. do you have any notes on this issue? would you mind opening a discussion? it might be OS or GPU or some technique we don't know. and if by some insane odds we've found a tmod issue it's best to get as many notes as possible.

Wow. This mod is basically the new Lights & Shadows at this point. It’s really good!

Congrats on 1.0!

HDR rendering is a rendering technique that internally uses higher brightness levels so that details in bright areas can be retained. The final image is still limited (via tone mapping) to the normal brightness levels, and tModLoader itself doesn't support HDR output. Thus, the lack of an HDR display is not the issue here. I don't know what's causing the all-white screen. Maybe it's related to your OS or graphics driver? What graphics API are you using?

if dev wants, i can give you hardware details if it helps

it's HDR, i believe. source: my laptop doesn't have the feature. i tested the mod by itself and anything relating to HDR immediately spawns the power of the sun directly in the screen.

The only time I've had issues are when using some optional optimizations, particularly from High FPS Support and other dedicated optimization mods

I've got a pretty chunky modlist myself that includes High FPS Support among several big content mods and didn't have any issues with a white screen, so there's probably something else going on.

For reference, here's my modlist (although it's unfortunate that it doesn't use the ingame names, just the internal names): https://pastebin.com/renJ456Z

mod*

ye like 63 other mods the big mode i use its calamity

Are you running any other mods?

ye its only show on ultra and i think high

Seems to bug out with the High FPS Support mod, causing most lights to flicker.

Does this problem occur only when using the ultra preset?

when i do ultra mode i have all lwhite screen any fix?

@2bluntz@once It works fine for me when using debug mode (from Rider). Is there any particular feature/config that doesn't work? Are you using any other mods?

@LunatiK something I found is that you shouldn't let the game run at your monitor's refresh rate. 240hz was too much for the game and causes some weird black artifacting. Try limit it to 120fps via whatever Radeon app thing is the equivalent of nvidia control panel. Lmk if that works

For me, Smooth Lighting is completely broken and causes the screen to go black/deep-fried depending on what is happening.
Using the Radeon RX 9060 XT

Muy Bueno

Amazing mod. Running a 14700K + 4080 on a 4K OLED display, had flickering issues but realised I had to turn frame skip OFF since my monitor handles it fine without but with frame skip on or on subtle it'll just tweak tf out.
I advise anyone with high refresh rate to turn frame skip off. No performance complaints so far, I'll check back if boss gameplay kills fps

幻想照明通过添加新的照明引擎和各种着色器来提高照明质量。

特性•平滑照明
•环境光遮挡
•准确的阴影
•幻想的天空颜色
•HDR渲染（色调映射到SDR）
•高光
•模拟法线贴图
•相机模式兼容性

为了获得最佳性能，请尝试根据您显示器的宽高比将游戏分辨率降低到1920x1080或1920x1200。

偶尔，在启动游戏后，这个模组可能无法工作。这通常可以通过重启游戏来解决。

如果您正在使用完整的HDR渲染，并且在使用其他模组时遇到图形故障，请尝试启用在“偏好设置”配置中标记为“完整HDRR的模组兼容性修复”和“在Boss战斗和事件中禁用HDRR”的设置。

某些瓦片在被绘制时会着色。例如，珍珠石被着粉色，以便其游戏内外观比纹理更粉红。平滑照明支持所有普通着色的瓦片。不支持修改后的着色瓦片。

Idk then. I don’t usually test the mod in debug mode, but I probably will later (in a few days) to see if anything’s wrong.

running tML in debug