Oh great idea for a mod!

@bada1 check your client.log file and post it in the discord

Hello! If i try to click on the unmet items, my game will freeze. Is this a bug?

@Qwazer join the discord and post your client.log file after replicating the freeze again

Hello! I tried using the mod with a bunch of others and whenever I try to click on the items being sold, my screen freezes and I can't do anything except force close the game. Do you happen to know what I could do to solve this??

@Wyneus Jacklz made the shop editor, or at least a shop editor, so if you are having a hard time with it you should probably comment there or join our discord and ask there

Hello, there is such a mod as NPC Shop Editor, but it is too difficult to understand how to set up NPCs, remove and add what they sell, as well as setting up the currency, is it possible to do this in your mod, but easier to understand?

@Tyler glad it worked, but you dont need to use my mod as a reference, just use the same process for the other items

@Jake Yes | are you trying to use my mod as a reference in your mod?|
I don't know why but adding(ItemDropRule.Common(ModContent.ItemType) Portable Shop Market & Shop Market Wall Mount shows Error. Shop Market all right does not occur error and with any items added from other mods

Thank you so much, that helped. | your last line should just be itemLoot.Add(ItemDropRule.Common(tableid)); |

@Tyler your last line should just be itemLoot.Add(ItemDropRule.Common(tableid));

are you trying to use my mod as a reference in your mod?

@Jake same error | CS0122 is inaccessible due to its protection level |

code:
ModLoader.TryGetMod("OneStopNPCShop", out Mod shop);
int tableid = shop.Find<ModItem>("ShopMarketPortable").Type; itemLoot.Add(ItemDropRule.Common(ModContent.ItemType<ShopMarketPortable>()));

@Tyler it sounds like you're trying to add it the wrong way. try this:

Modloader.TryGetMod("OneStopNPCShop", out Mod shop);
int tableid = shop.Find<ModItem>("ShopMarketPortable").Type;

from there you should be able to create an itemdroprule to register to your item bag.

I wanted to add a Portable Shop Market item to my mod bag(ItemLoot.Add). But build gives the error CS0122 is inaccessible due to its protection level the same error gives Shop Market Wall Mount and with Shop Market Everything is normal.

nvm it worked i just placed it somewere else so i would't interact with anything else

I can't open shop market menu when it is placed at the ground

life changing

@Jake Thank you. :) ill go post on the fargo's mod to see if there's anything they can do.

@AridRaider unfortunately theres nothing you can do to fix this. ill see if i can make a compatibility patch with it but no guarantees. you could also post about it to the fargos mod developer and see if they have anything to say.

as for the cheapest vendor thing, i wont change it to hide the same item from different vendors, but i will add the ability to sort by price in the next update so its easy to find the cheapest vendor

@Jake So there's nothing I can do on my end to 'fix' this? Another thing with added mods sometimes the same item is sold by different merchants... is there a way I can just have it sell my the item from the cheapest vendor and not include the others? Thank you for the response :)

@AridRaider to be a bit more technical, the shop market finds shop items at mod reload. the squirrel npc edits the shop items when in the world. so there will be some items that the market cannot display.

it might be possible to fix this on my end, but could also be fixable on fargos end if they declare shop items at mod reload rather than in game.

@AridRaider the squirrel's items are determined by your inventory, which means it doesn't work with this mod.

Shop Market isn't detecting items sold by Squirrel in Fargo's mod.

@ModdedNostalgia interesting. ill make a note and see what i can do

Interesting bug with "Bosses as NPCs" with the Torch God setting enabled (to reduce the number of npcs for performance): you can buy all of the items from the Torch God that he can possibly ever offer regardless of progression. An option to blacklist certain NPCs in the settings might be helpful for this as a compatibility fix and for any other NPC that may come up that has issues like this that break balance.

@L115 next update should fix this issue

@billyjrbultman check your client.log file. if theres any errors in there, join the discord and post it in the appropriate channel

does any one know my game freezes everytime i try to buy something?

On further testing, looks like if you buy more than one item from the Market, it only costs you the money for one item. So you could buy a whole stack of potions for the price of one. Very exploitable

I noticed that when using the "Potions Price Multiplier" for the AlchemistLite NPCs, it doesn't apply to the prices in the Shop Market. My modpack is rebalanced around this, so a fix or generally more control over prices would be really appreciated

Would be nice to have portable version

the problem was no housing, thank you!

@calvinosinclair what version are you running? check your filters and make sure your npcs have homes

hello, the shop stopped working recently. it shows nothing when opened

@CaLiS I had the same problem but I *think* I know why. If you change the shops of the npc (for example the brewer npc from alchamist has 5 shops and you can change between them) and the shop is empty, it doesnt show in the shop market

Ah a shame but good to know then, thanks for your responses

@CaLiS looks like it might a be bug then. in the 1.4.4.9 preview version, the shop system has changed a bit so this issue will likely be automatically fixed

I have double checked my filters and it seems that the only thing on is all items, however it is not showing everything still, I scrolled down to check other filters to make sure and that is indeed the only filter on
https://steamcommunity.com/sharedfiles/filedetails/?id=2985455948

@CaLiS double check your filters

We are playing on stable version

@CaLiS are you on preview or stable

Hi, this mod has always worked great on previous playthroughs but on our current one for some reason it tells me its only showing 27/35 npc's shop items? Is this intended or a bug?

@4k1n0m this issue will likely be automatically fixed when stable updates to 1.4.4.9

when https://steamcommunity.com/sharedfiles/filedetails/?id=2563082541 this mod is enabled the shop market block doesn't show the items from the added shop

Oh wait never mind.. I missed your second reply about 1.4.4.9 stable... My bad! ^^;

Just noticed that the not-yet-researched filter meant for "added for the next update" wasn't added in the 27th march update.

@EasyCo there is a basic filter to sort by item types, but ill add in a way to sort by name and stuff for the next update

Seriously enjoying this so far, is there anyway you could add a sorting feature? So you could sort by item value, damage, alphabetical, etc.? I've got a bunch of mods many of which add NPCs or add more items to vanilla NPCs, and having a sorting feature would really help with going through those massive lists lol.

Thank you again for the mod!

Hey! This mod is very cool! But when I go to the market, the cost of goods is not displayed. Everything works except for displaying the price

@NovaKatt😽💚 itll be when tmodloader stable updates to 1.4.4.9

So when is the next update coming? :)