Every time a trade ship comes, two of the same type come at the same time. They both have different names and inventories, but it's always two bul goods, or two exotics, or two combats, etc. I don't have many mods installed, just utility stuff so I don't think anything else is affecting this

Thank you!!!

Thank you so much! It's super aggravating the arrival of orbital traders depends on the storyteller picking the event... It makes it so much harder to run a trading colony, and it feels weird when mods like Starport and Hospitality can have your colony bustling... you'd think a trader would show up frequently to sell to anyone there!

@Kaedys you are correct.

I made this mod because I was unsatisfied with how unreliable xml trade frequency mods are. Anyway this mod is ready I'll post it today.

That's not the same thing as this mod. That mod just applies an XML patch that reduces the defined frequency between traders by a fixed amount. Traders spawning is still dependent on the storyteller "selecting" the trade ship as the event that spawns, and other events can get in the way of that. This mod instead forces traders to show up at certain intervals, completely independent of the storyteller event logic.

You might want to hurry up! https://steamcommunity.com/sharedfiles/filedetails/?id=3524108265&searchtext=More+Trade+Ships

It depends. I have a busy weekend but that might not stop me. Maybe I'll have some of my mods updated tonight. Maybe I'll run into problems and it'll take me until next weekend. I doubt it's going to be more than a week.

Thanks for planning to update. Do you have a rough timeframe for those about to set up new modlists? 1 week? 2 weeks? 1 month? more?
I am not in a hurry, but it would be great to know when I can start checking

yeah when I first made this mod a long time ago, if there existed ways to insert custom save data into saves, it wasn't well-known. So I had to improvise with possibly one of the gnarliest harmony hacks ever deployed into a rimworld mod. I put great care into making sure it would never corrupt anyone's save and it has multiple layers of redundant error and null checking. I'm surprised that hack has been in the code for so long without ever getting broken

If you don't see any red errors, you're fine.

When I update this for 1.6, if I can find a proper and better way of inserting custom save nodes into rimworld save games, i'll get rid of that ridiculous code.

@Snappa huh, I never thought of that. I'll see what I can do next time I get a chance.
@saltyThorn that option only makes it so that traders generated with this mod won't be any of the disabled trader types. When the game decides to generate a trader naturally, it follows vanilla trader generation rules.

One issue I have is i have more trader varieties than fit in the mod options window, is it possible to add a scroll bar to the menu or to make the window bigger?

also, is there a config file somewhere that i would be able to edit manually to change which traders will spawn and which ones won't? thanks

Are you sure you have a trade beacon? It won't let you open the trade window if there isn't at least 1 owned trade beacon on the same map as the trade console. I just tried the mod with a minimal mod list and also with my personal modlist, which has a lot of crap in it, and it worked, but this was coming from a clean install.

Try deleting the file called "Mod_2296557502_TradeShipsNoMatterWhat.xml" in "Ludeon Studios/ Rimworld by Ludeon Studios/Config". This might be in your AppData folder somewhere but for me its in home/.config/.

Hi, i can't open the trade windows since yesterday, i haven't add any mods. Is there a way to "purge" a cache or something for your mod please?

Not easily. I don't doubt it could be done, but that's going to have more issues with peoples modlists and I'm not one of those Rimworld mod creators that fixes issues fast, lol.

Could trade ships be changed to a global event, similar to solar flares? That way, it wouldn't matter how many colonies you have...

Yes, that is actually how it works. There currently isn't a mechanism in the mod to increase the frequency based on how many colonies you have, maybe that could be a possible feature to add in the future.

Are the number of orbital trader events divided by the number of colonies you have? I just founded two new colonies, and only my main colony has a comms console. It seems like I'm getting a lot less orbital trader events at the main colony now.

Bit of a fringe case, but yeah, just a normal colony map with mechanoids, as the humanoids were in an "underground" submap, specifically the underground bunker from Ancient Urban Ruins. With the help of Zal i fixed it by patching the IncidentDef of trader arrivals, all it needs is changing the <requireColonistsPresent> from true to false. While technically no fault of this mod, and i can definitely see this causing problems in other scenarios, perhaps you'd like to implement a patch as an optional toggle?

Late reply, but do trade ships fail to show up even if you actually have a settlement on the map? I had to put in code that prevents traders from showing up when the player doesn't own a map tile because it makes the game glitch out and crash if that ever happens. Trade ships won't show up if you're raiding a map tile you don't have a base on (or camping on it) AND don't own at least 1 base.

If you actually have just a normal base with mechanoids and it's not showing up then I'm not sure what's causing it. I'll look into it when I get a chance.

"no matter what" well i found situation where thats not the case: when no (human) colonist is on the map (mechanoids dont count apparently) :(

go to options > mod options > Trade Ships No Matter What and then edit the sliders to your liking.

Is there any way to adjust the frequency of the ships? I find vanilla too sparse but that this mod brings them too often!

ok thanks i'll check and post back in case of problem :)

Ok well I went ahead and pushed the more refined updated version. I can't remember if I forgot to compile the last one with 1.5 references or not but I for sure know I did it with this one. @pcgames-food see if that fixes your issue.

Of course, if i'm wrong and it turns out this breaks everyone's game except mine, you can always copy the Assemblies folder from the 1.4 folder into the 1.5 folder as a quick fix.

what recycling mod are you using? That type of conflict shouldn't even be possible so i'll have to look into it. It's possible that I compiled it with the incorrect 1.4 references.

hi i noticed in your update comments, that you recompiled the dll without code changes needed - do you know if there is any way for a dll to work "without" needing a kind of hardcoded reference? (im asking because my recycling mod stopped working in 1.5 but the dll didnt need anything when going from 1.3 to 1.4) :)

Thanks, I noticed that too. The 1.4 version works well in 1.5 - there are some minor mod settings bugs that most people probably won't ever notice. I already have those bugs fixed along with the harmless startup error @elxxx reported for the next update. I just want to make sure it has been tested thoroughly before I post it. Expect tomorrow at the earliest.

@Windows XP anyway mod works well even with 1.4 version, use it before an update and all works well, configs works, no errors, trading ships are flight twice a day (with proper settings), so actually the only update needed is about.xml edit.

@Windows XP thanks for the quick reply. Hope you fix the error soon.

Yeah I'm working on it. It's a 100% harmless error that doesn't happen in my other mods that use configurable settings so you can safely ignore it. Everything else works without issues, even the xml save file entry feature (which is enabled by default to make trade ship appearances more consistent).

Ironically, if you replace the 1.5 assembly dll with the 1.4 one, that makes the starting message error go away. It seems to be an artifact caused by compiling it without monodevelop or visual studio. My other mods don't do this when compiled this way so I'm sure I'll find the fix for this error soon.

Hello. @Windows XP, i think since yesterday you updated this mod. And now i get this error message: "Failed to find TradeShipsNoMatterWhat.TSNMWSettingDef named default Settings. There are 0 defs of this type loaded." . Can you help?

I've set my continuation to unlisted (and will remove it before long) now that you've updated. I'm always happy to hand one back to the original author. Thanks!

i found a way to compile basic rimworld mods without monodevelop or visual studio. It works for me when I play this on 1.5, if anyone has issues let me know. If this actually works for people, I might be able to use this to update some of my mods.

Still works on 1.5, looks like someone else is maintaining it. I used to mod Rimworld when monodevelop was easier to get working on Linux. Now it's really hard to get monodevelop running and it only runs on a select few distros. Unless I find a different way to compile RImworld mods I'm not going to make them anymore.

Even if I get that figured out, i'm not planning on taking this one over unless/until I think of new features to implement.

1.5 update: https://steamcommunity.com/sharedfiles/filedetails/?id=3278858782

1.5 pls

1.5 update would be great.

Working fine for me in 1.5 with Anomaly DLC enabled. I will make sure to come here and leave a comment if I get any erros relating to the mod.

15

does this need to be updated to 1.5. or can i just activate it in rimworld regardless?

yo gonna update bro?

Please update to 1.5 !!

can you add a mod option to turn off notifications, i make them come pretty frequently

I presume this simply has a timer of 3-5 days and when it is over it forces the game to spawn one, disregarding everything else like the storyteller naturally spawning them?

I will accept the hug on their behalf, and it can be full homo

can i hug you for this ? (no homo)

Thank you, thank you and thank you.

i love you
this should not be a stor wee tell onwy evemt ):
its so annoying having huge periods of not trading

You are the best.

Don't believe that's actually an issue with this mod. This one doesn't modify the trader stock at all, it just alters the spawn behavior. Those errors mean that one of the elements in the trader stock is null-refing, which is an issue with a mod that adds or alters those trader stocks, or perhaps an incompatibility with another mod that *removes* one of the items in their stock definition.