I verified that I have version 1.34, but it seems like that patch is still taking up 0.250ms average per frame, which is quite a lot, and is around the same as I saw before your update

ZuluFox: Thanks for the report. I've never done any sort of performance monitoring on Rimworld before so I appreciate your efforts. I've just added some caching to the method to the CombinedDisabledWorkTags Prefix method. The other two you mentioned aren't in my code but they probably reference the method I'm modifying. I hope you notice a difference. It should only be checking the disabled work assignments when a pawn gets a new title or experiences a status change that would affect their work. It was checking every tick for each pawn before which is... a lot. You're looking for version 1.34. It sometimes takes Steam a bit to update the mod.

For some reason this mod is causing performance issues, according to Dubs Performance Analyzer the issue is the "CombinedDisabledWorkTags_Patch", and specifically RimWorld.QuestUtility:GetWorkDisabledQuestPart and RimWorld.Quest:get_State. Any chance this could be optimized somehow?

I've updated the mod in an attempt to resolve the Violence-Disabled gene being ignored. Hopefully that solves the problem!

Rylock: Thanks for the report. I made this mod before biotech so there were no genes so I didn't need to take them into consideration. I have never even played with that DLC so I don't know what is or isn't possible. I'll investigate this and see if I can resolve it though.

This mod seems to disable the Incapable of Violence gene. Base with DLC's if this mod is added pawns can equip weapons and attack. Without this mod it works normally. I don't know if it was present before 1.6. Otherwise this is a great mod, thank you.

Graenwitch: You're welcome! I'm glad you find it useful!

Thanks for updating this! This mod is essential for all my royalty-involved runs

DSFireKeeper: Thanks for the error report. I've edited the mod to remove Ghouls from the work assignment logic so you hopefully won't have issues with them anymore! Version 1.32 should fix your issue.

Hello, I found that after installing this MOD, My Ghoul won't be able to hit enemy. Could you resolve this bug？（When I turn off this mod ,it can hit enemy again)

@FelonyMaker: You're welcome!

Thank you!

Manluke: It's people like you who keep me doing it! Thanks for your support!

Thanks for keeping this updated.

Monkey Magic: The default setting for "Will work passionate skills" is true while "Will work only Major passionate skills" is false. I'm not exactly sure why you might have had an issue with it in your game. I'm glad you figured it out though! Thank you for the feedback.

"Also re-enables passionate skills" -from description

Well..

I've been testing to see if this mod is compatible with one I made recently, and it did not appear to be so, as the passions were no re-enabled. Curious, I tested just this mod and required DLC and it still didn't work

Then I came back here, and read through that long line of patch note to see there were mod options. Checking those, I saw that the default appears to have these switched off. You may wanna change that line to:

"Also re-enables passionate skills but, must be enabled in the mod options "

Iunno if it is because this was a pre-exisitng save, or whether the mod default is set to off, but yeah. I was close to disabling coz I thought it was broke :/

The Blind One: Your research into this issue was really impressive! If I ever dig back into it, I'll see if I can sort it out. I imagine the work you did will allow me to do that.

Btw thanks for this mod <3

Okay so after some trial and error here's what I found;

If you already have a pawn with a title that requires a grand throne and then install this mod, they will still want their own grand throne. You can fix this by demoting them to a point where they don't need one and then repromote them to their title using dev mode. This fixes them and they no longer require a grand throne.

Secondly, if I don't assign a throne to lower titled nobles then they don't care about having a throne room at all nor about the chair that they would be in but if I do assign them a throne then they do care about it and the chair* they are in. (*if you didn't reset them, they will want a grand throne for example, a title reset as prescribed fixes this bug)

So yeah, it's a bit janky when you install it mid playthrough. Perhaps add a disclaimer about this case in the description so people know how to fix it / know it does actually work.

The Blind One: I tested on a new game with only my mod installed and the latest updates and it worked as I expected. I used Baron and Count titles for testing and it worked fine. I'm not sure what to suggest other than other mods you have may be adjusting the "Seniority" ratings of titles which is what my mod uses to determine who is highest rank. Sorry I can't be more help!

Can confirm that this isn't working as intended anymore.

My Baron still demands a grand throne room despite my Archon (Count) already having a grand throne.

Yeah.. this mod is not working. Before I installed this mod the throne room is not a requirement for a novice now it's asking me for a throne room already unlike before. Plus the Knight title still needs a throne room even though I deactivated it on the setting. Just like the guy below me. It might have conflicts with the latest updates or with Empire itself.

Perhaps it could be fixed by making a throneroom for the knight, then accepting the bestowing ceremony. And once the title is given, get rid of the throne room and see if it's fixed?

Could be an issue of not having this Royalty Tweaks mod's options turned on by default. I thought this was active by default, but then I checked the options of this mod and just found out that it was indeed not turned on.

yutheboxer: Thanks for letting people know. You might be able to put my mod later in your mod order to fix that, but then it's possible other features of their mod might not work. Hard to say.

This mod seems to conflict with Vanilla Factions Expanded: Empire mod. The knights still seem to require their own throne rooms, despite having toggled this mod on.

vanilla factions expanded empire thats what it is @Mobius

@Misty Step: I don't know what that is so can't say. Feel free to try it and post your results!

is this compatible with VFE Empire?

Kalisa: That's not intended/ I never looked at the mechanics for leveling up so if it cares about the throne room, I don't change it. Thanks for letting me know. Next time I'm in the code, I'll look for that.

not sure if this is intended, or perhaps a mod conflict im getting, but having to still need a throne room for pawns of lesser rank to at least rank them up, once they are ranked up though i can take the throne room away and they are fine. So they still need the throne room initially to get the rank even if its a lesser rank then the highest noble you have.

alienxtown: Hoorray! It's dumb that you needed to do that. Thanks for letting me know it's working for you!

An unsub/resub also seemed to force it to 1.3 and clear things up for me!

Олег Мерк: I've never played while the Ideology DLC was active except to test my mod's functionality so I don't know what gameplay aspects it has. I imagine it's technically possible but I think if I was going to do that, I'd probably make an Ideology focused mod to keep things consistent. I haven't actually played Rimworld since after Royalty was released so I very much doubt I'll do it.

myteon: Thank you so much for confirming! I was getting pretty worried there! I'm so glad it's working for you now!

Is there any possibility to add same skill passion unlocking feature to roles from ideology?

K. I unsubbed, resubbed and now I have 1.3 and IT WORKS! Factions are appearing and the work tab is populated.

https://imgur.com/a/VFUBQDK

I subscribed to my own mod and you can see that it's showing 1.3 for me. I'm not sure how to get your system to update but I think you're having issues because you're running an old version. I hope you can sort out why your system isn't downloading the most recent versions.

Hi there, similar problems to other peoples but no RimHUD.
Game version 1.5.4.085
All DLC running,
mod says v. 1.21 in mod manager.
Maybe you are working with a local version 1.3 but the workshop is still using 1.21? ( I say this because I expected it to say 1.3 in the mod manager and the jump to page takes me here where 1.3 is the cutting edge) Hope it helps, this is a must have mod for me

alienxtown and kifo: I started a new game with RimHUD installed, both before and after my mod in the mod list load order. I had no issues generating factions and no errors in my error log. Unfortunately, I can't fix an error I can't duplicate. I appreciate you guys letting me know about the issues you are having. I wish I could do more to fix it.

What version of Rimworld are you using?
Do you have all DLCs installed and running?
What version of the mod are you loading? 1.3?

I have all DLCs loaded and am running version 1.3 of my mod and Rimworld version 1.5.4.085

Hi, I'm having similar issues to others with this mod. May have some sort of conflict with RimHUD? I was also getting rimhud errors (rimhud disabling itself) until I narrowed it down to this mod causing job and world generation issues, with rimhud working fine after the removal of this mod.

I'm not too familiar with how mod conflicts work, but hopefully that info is helpful in some way!

kifo: I'm not sure how my mod could affect factions. It only modifies jobs people are willing to work. I'll see if I can duplicate your issue though and let you know if I can.

I was still having the same problem. I will get no factions during world generation. Not sure where the conflict is as I have over 300 mods.

There were other syntactic changes to the method I mess with that I thought were minor and inconsequential but I've made those changes in my method too now so the only difference is in the part where I modify royal work definitions. I've uploaded a new version. If your game is for sure updated to the most recent patch and you're running version 1.3 of my mod, please let me know if you encounter any errors. I can't get it to throw any but I might not be doing what you're doing.

If you're still having issues, please confirm that you're running version 1.221 of my mod and let me know. I'll investigate further.

Yep, looks like it was fixed, thank you for your work! o7

@Amanda @Poor Little Meow Meow your mod versions are 1.19. Verify files or update your local mods, depending on how you installed the mod, and check if your error still occurs. It shouldn’t though!

I encountered the issue despite Mobius already released a patch several hours earlier. The game just refused to download latest mod version. You can check the mod version in-game. If it's not 1.221 shut down game, unsubscribe, wait for Steam downloads to finish and then resubscribe.

Can confirm, removing this mod fixed my problems too. Log attached: https://gist.github.com/HugsLibRecordKeeper/f2a42190305f7df368cfbbf58ccfe329

yo thats my logs :susage