"LMB = Attack, Can't Cancel Menus" Fixed in Latest Beta

[tintingaroo]

Update: This is fixed by TC in the latest beta

If you map left-mouse button to attack you can get stuck in menus where Cancel (Escape key, Focus/Cast action) has no effect.
It doesn't only happen in God Home, but in the main menu as well. It's easy to miss the problem in the main menu, because those screens have a 'Back' option. (Set attack to left-mouse and then try backing out of a main menu screen with Escape, it won't work. Try it with attack set to something else, and it will).

I was close to finishing a guide with a workaround to avoid the issue (swap primary/secondary mouse inputs (left/right mouse buttons) in Windows), but then I figured out how to implement the basis of that workaround within the code. While doing that, I found the actual section of code that causes the issue...

I've done some testing and will make a guide, but would like some LMB = Attack players to test.

Apart from avoiding the lock in, I've changed the behaviour of Attack to be Confirm/Submit. It originally acts like Cancel if Attack is not mapped to left-mouse button.
So, you can now use left-click to confirm in in-game menus - e.g. to select/deselect charms, bindings, boss difficulty. (It's just the left-click, not a mouse over cursor, still have to highlight the option with keyboard as usual).
(Can't be used to place markers on the map though, have to use Jump action as normal).

To set it up:

• Go to your HK directory and then hollow_knight_Data\ > Managed\.
  
  
• In the Managed folder, for backup sake, rename Assembly-CSharp.dll to, for example, Assembly-CSharp.dll_BAK.
  
  
• Download and paste in this edited version into the Managed folder: https://drive.google.com/file/d/1C2h0O9ahRv7H2YuKxY2vi9OvHec-V6eu/view?usp=sharing.

Then play the game, test some menus, do some stuff, get killed by kill AR.

Let me know how it goes.

[tintingaroo]

I haven't tested buying from the merchants with the left-click submit yet, so if it works OK let me know.

[🉑 rezno[R].technology]

Ah, so one mystery of using the back/cancel button by some players is solved! They were using the proper button, but custom mapped to the back/cancel action 🙂 Great work and investigation as always, tintingaroo! ✅
The "Escape" key behaviour finding was really interesting, and I can imagine it can be very confusing to people.

Now reading this gave me an idea: Where else can this game behaviour cause problems?
I wonder if a similar thing may happen, if a player maps "attack" to the "jump" button (on a controller or keyboard for example, if a player prefers it that way). Or does it only work on the mouse.

[tintingaroo]

I would think it only happens with the mouse but I'm not so sure - gonna test it. I don't think they have actual Cancel/Confirm buttons (like regular Xbox B/A) but just mapped to game actions, but will see.
The part in the code I found will only affect left mouse = attack.

Update:
OK, so B/A are dedicated Cancel/Confirm, they override the cancel/confirm behaviour of the actions. I didn't get locked into any menus in my testing but what can get messed up is the button prompts. The prompts took their leading from the actions - whatever button is mapped to Jump will be shown as Confirm, what is mapped to Focus/Cast will shown as Cancel. So setting B to Jump results in B being shown as Confirm, but its a dedicated Cancel so will always cancel on press.

With pure keyboard there are no issues - it could be a problem if Enter or Escape were being mapped to things I assume.

[skelclique]

Can you help me? I replace the files and when opened the game I got this error, "UnityPlayer.dll caused an Access Violation (0xc0000005) in module UnityPlayer.dll at 0023:6839ff60." thank you for your attention.

[tintingaroo]

Are you playing on Windows? What version of the game (GOG, Steam etc)?
Are you playing the new beta version or previous main release?

[Perseus]

It's fixed in the beta from 7 hours ago!

Team Cherry původně napsal:

EDIT: v1.5.61.11779 is now available, with the following fixes:
[..]
- Fixed issues with binding mouse buttons
[...]

Unless it's another mouse binding related issue that i somehow don't know about.

[tintingaroo]

:D
TC on a roll!

[skelclique]

tintingaroo původně napsal:

Are you playing on Windows? What version of the game (GOG, Steam etc)?
Are you playing the new beta version or previous main release?

Sadly i don't have an original copy of the game, I'm playing on Windows in v1.4.2.4, probably you don't have a fix to that version :d but thanks for your attention.

[🉑 rezno[R].technology]

skelclique původně napsal:

I'm playing on Windows in v1.4.2.4

The latest stable HK version is v1.4.3.2 from 2018, this fix is most probably for this version.
When you buy the game on a Steam Sale (I hope, so I'm not saying "if"), you can check the latest Beta 🙂

[skelclique]

🉑 reznoR původně napsal:

skelclique původně napsal:

I'm playing on Windows in v1.4.2.4

The latest stable HK version is v1.4.3.2 from 2018, this fix is most probably for this version.
When you buy the game on a Steam Sale (I hope, so I'm not saying "if"), you can check the latest Beta 🙂

If I buy the game, i need to buy the DLC's? Or they are free?

[kanna]

skelclique původně napsal:

🉑 reznoR původně napsal:

The latest stable HK version is v1.4.3.2 from 2018, this fix is most probably for this version.
When you buy the game on a Steam Sale (I hope, so I'm not saying "if"), you can check the latest Beta 🙂

If I buy the game, i need to buy the DLC's? Or they are free?

The non-soundtrack DLCs are free and come immediately with the main game.

[skelclique]

kanna původně napsal:

skelclique původně napsal:

If I buy the game, i need to buy the DLC's? Or they are free?

The non-soundtrack DLCs are free and come immediately with the main game.

Hum good, ok thanks! :D