Store Page
The Binding of Isaac: Rebirth
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

The Binding of Isaac: Rebirth

Store Page
The Binding of Isaac: Rebirth >  Workshop > 󰀏Niko's Workshop > Full Pickup Prevention > Discussions
Full Pickup Prevention
Description Discussions2 Comments138 Change Notes
Stlkngne Oct 27, 2022 @ 6:13pm
MCM Pure
Hey, I noticed that the settings aren't being saved between runs when using MCM Pure. This is because Pure no longer saves other mod's settings within MCM's save file (which is a feature that MCM Continued supports). Pure expects you to save the settings within your own save file.

Originally posted by MCM Pure FAQ:
Q: What do I do if saving settings for a mod does not work between game launches?
A: Mod Config Menu is not in charge of saving any data besides the ones in the "General" and "Mod Config Menu" pages. If an individual mod does not properly save its data, then you should contact the author of that mod.

You can take a look at the quick start guide for more info: https://github.com/Zamiell/isaac-mod-config-menu/blob/main/docs/quick-start.md

For this mod, it looks like the data in ModConfigMenu.Config["Full Pickup Prevention"] is used during the run, but doesn't get loaded from file.
Last edited by Stlkngne; Oct 27, 2022 @ 6:50pm
< >
Showing 1-3 of 3 comments
󰀏Niko  [developer] Oct 28, 2022 @ 7:55pm 
Originally posted by Stlkngne:
Hey, I noticed that the settings aren't being saved between runs when using MCM Pure. This is because Pure no longer saves other mod's settings within MCM's save file (which is a feature that MCM Continued supports). Pure expects you to save the settings within your own save file.

Originally posted by MCM Pure FAQ:
Q: What do I do if saving settings for a mod does not work between game launches?
A: Mod Config Menu is not in charge of saving any data besides the ones in the "General" and "Mod Config Menu" pages. If an individual mod does not properly save its data, then you should contact the author of that mod.

You can take a look at the quick start guide for more info: https://github.com/Zamiell/isaac-mod-config-menu/blob/main/docs/quick-start.md

For this mod, it looks like the data in ModConfigMenu.Config["Full Pickup Prevention"] is used during the run, but doesn't get loaded from file.

Thanks for letting me know, I will try to add support for "MCM Pure" if and when I can find the time for it.
#1
Stlkngne Jan 4, 2023 @ 7:25pm 
I added the following code as a stopgap for now.

local json = require("json") function mod:onGameStart() if mod:HasData() and ModConfigMenu then local _, tbl = pcall(json.decode, mod:LoadData()) if type(tbl) == "table" then -- todo: validate data ModConfigMenu.Config["Full Pickup Prevention"] = tbl end end end function mod:onGameExit() if ModConfigMenu and type(ModConfigMenu.Config["Full Pickup Prevention"]) == "table" then mod:SaveData(json.encode(ModConfigMenu.Config["Full Pickup Prevention"])) end end mod:AddCallback(ModCallbacks.MC_POST_GAME_STARTED, mod.onGameStart) mod:AddCallback(ModCallbacks.MC_PRE_GAME_EXIT, mod.onGameExit)
#2
󰀏Niko  [developer] Sep 7, 2023 @ 5:31pm 
MCM Pure support has been added. Thanks for the link @Stlkngne
#3
< >
Showing 1-3 of 3 comments
Per page: 1530 50