Does this add the trait throughout the world or is it just for custom creator?

I'm not quite sure. They're all unique traits, so you should make a backup save before making the attempt.

There is a better version of this I made recently called "Dynamic Commander Improved"

does this work with agot?

I've added my discord to the description, so if anyone has suggestions or tips, we can discuss there going forward.

Ill take that into account. My main goal while designing these traits was to just have fun, but for more serious stuff like what you guys are requesting, ill do what I can to maybe look into how to develop them.

I seen a few perks that have "levels" to them and Im thinking of trying to do something similar to that soon so I don't have to do the tiers.

You could try to implement it through events or decisions. A decision could be like "learn swordsmanship" and after you have the first level, it would change into "improve swordsmanship" etc with maybe events that pop up after the decision that have a chance of failure.

Winter, review the war veteran mod, it gives out a trait based on amount of victories.

That is a good starting point to learn. I like more martial aligned traits, but ones that are earned. Congenital like this doesn't make sense, but kudos for doing it.

If you mean do you get them dynamically, not at the moment.

If you mean can you earn them through birth, then yes. The chances are 0.5 and 0.25 for tier 1 and 2 for both sets respectively.

I'm quite unsure about how to go about dynamically earn-able traits (though id love to figure it out)

Are these naturally attainable to the player?