Is there a way to automatically accept only "good" trades?

[LRFLEW]

I was thinking about making this a feature request on Github, but figured I should ask about it first, in case it already exists. I looked through the documentation, but didn't see anything about it.

So based on https://github.com/JustArchiNET/ArchiSteamFarm/wiki/Trading#steamtradematcher I see that adding SteamTradeMatcher to TradingPreferences, then any trades that are "good" or "neutral" will automatically be accepted (if the 2FA is setup correctly). If you have MatchEverything as well, then "bad" trades will be automatically accepted as well. I want to be able to use the new MatchActively feature, but I don't want to accept "neutral" trades automatically right now. I'm only interested in having the bot accept "good" trades, as that's all I need right now. It would also be nice to be able to explicitly ignore "neutral" trades as well, so I could have it automatically accept "good" trades, automatically decline "bad" trades (with RejectInvalidTrades), and ignore "neutral" trades to be manually accepted or declined.

Does this feature exist in the current code? If not, would this be feasible to do? Looking at the Public ASF STM Listing, I see that the users are separated by whether they have MatchEverything enabled, so I don't know if adding this feature would require updating the listing server's code to also sort by the handling of "neutral" trades as well.

[Rudokhvist]

ASF won't send neutral trades, but it will accept those. Why do you even care about it, you will lose nothing with it, because it's neutral; and after all your sets are (actively or not) matched there will be no more neutral trades (unless you spare cards). And this will help other users, in other words YOU gain benefits from this fuctionality on other people bots. And no, there is no way to reject neutral trades and accept only good, and I doubt Archi will consider adding this feature - neutral trades are there for a reason. You may make your fork and change this just for yourself though.

[Archi]

Short answer - no, there is no such option and it won't be considered, neither in suggestion nor PR.

ASF is supposed to be liberal and help everybody around as much as possible. If your friend has A B B and you have A C D then you can help your friend by giving him C or D and not lose anything in the process by accepting B from him. ASF bots are first and foremost supposed to help themselves, but secondly help others. If you disagree with this then you also disagree with the core principal upon which the ASF STM trading module was built, therefore you're not target user of this feature to begin with and you should seek other program that does what you want, since this feature does not match your expectations.

[LRFLEW]

I figured this might be the case. I'm disappointed that the feature won't be considered but I understand. The line "you're not target user of this" is something that I noticed was a possibility when I first saw the "bot" setup. I'm only using it for my "primary" account, so the whole "24/7 bot" system is counterproductive to my use case (I found it for its card farming ability after Idle Master wouldn't work).

The problem with the advice "you should seek other program that does what you want" is that there really isn't any good alternative from what I've found. I was using steamtradematcher.com before, but it's stopped working reliably (and also isn't automated like MatchActively is here). If you know of something that might work for me, please do let me know, though.

I would also assume that this feature would help mitigate problems with item rarity. On the wiki page describing the config option MatchableTypes, it mentions that it won't consider item rarity in the trade. I don't care about trading away a rarer duplicate, but would like to manually verify the rarity on any neutral trades. Without this, I don't want to enable the trading for emotes in case I lose an emote I actually use, even if I want to get rid of duplicates.

Ryzhehvost mentioned I could always fork the project and make the change for myself. I might end up doing that just for my use case (I have some experience with C#, though I mostly work in C++). I'll be careful of the Statistics option if I do that to avoid causing issues (such as with your trade bot listings).

[Rudokhvist]

Originally posted by LRFLEW:

I don't want to enable the trading for emotes

Then don't. It's already possible.

[LRFLEW]

Originally posted by Ryzhehvost:

Then don't. It's already possible.

I understand that. It's even disabled by default (I think?). I was trying to say that I *would* enable it if I could manually accept/decline any neutral trades, but won't if I have to accept all neutral trades. Sorry for the confusion.

[Archi]

You can already do that - by not using listing or automatic matching to begin with. Like I said, this feature has strict set of requirements, and while your use case is valid, ASF is not the right program to satisfy it in particular. You're looking for manual STM matching, and ASF's one is automatic by definition, including its own fairness logic that you do not agree with.

[LRFLEW]

I've thought about this more, and realized I may be looking at this the wrong way. I understand not wanting to change the behavior for accepting neutral trades. I realized what I wanted wasn't what I asked for. Would you consider a PR that allowed enabling MatchActively without enabling SteamTradeMatcher?

The way I see it, MatchActively and SteamTradeMatcher are related features, but are ones that don't directly interact with each other. Right now, to enable MatchActively, you need to also enable SteamTradeMatcher (according to the Wiki at least), which automatically accepts trades and adds you to the STM Listing (if you are otherwise eligible). However, SteamTradeMatcher specifically automates incoming trade requests, while MatchActively only automates outgoing trade requests. From the Wiki page on Trading, these two lines seem to indicate that a user running MatchActively will never receive a trade request from another MatchActively user:

In order to make use of [MatchActively], you have [to] ensure that you have MatchEverything disabled

If you meet all of the requirements above, ASF will periodically communicate with our public ASF STM listing in order to actively match Any (MatchEverything) bots currently available.

Based on this, I got that MatchActively users will send trade requests to MatchEverything users, and no user can be both. Therefore, it makes sense to me that there wouldn't be any issue allowing users to enable MatchActively without also enabling automatic processing of incoming trade requests.

[Archi]

Now this makes a lot more sense, yes, MatchActively could work without STM being active at the same time, but whether it should is entirely different story. By using my service and the bots that participate in it, the least you can do is help the listing by accepting neutral+ trades from other users in exchange for the same done to you from the others. I believe this is fair considering you're already taking far more than you give, and at least right now I do not plan to change it, but maybe I change my mind eventually.