Kaedys 27. juni 2023 kl. 8.55
Please fix link parser for comments
As an example from this mod, someone posted the following in a comment:


Steam takes the URL in that, and replaces it with:


Edit: ok, Steam is parsing the above, despite being in a code block. There's a Steam linkfilter prefix on the above URL. Go to the above mod link and mouse over the link in the comment (currently the third comment down, dated June 22 @ 4:15 PM (EDT), by user Titan Nya) to see what Steam replaces it with, since apparently their link replacer is exceptionally aggressive.

This has two major problems:
  • It is duplicating the protocol portion of the URL (and forcing it to HTTP instead of HTTPS, shame on you Valve)
  • It is inferring the surrounding parentheses are part of the URL

When clicked on, this forwards the user to the URL:

Which, of course, fails to load, as that's not a valid URL. The user must either hand-copy the URL in the comment (which, incidentally, the Steam client makes annoyingly difficult), or figure out how to manually modify the URL to fix this, which most browsers make more difficult by hiding the (duplicate) http:// prefix that steam added.

If you're going to parse URLs out of comments, please parse them correctly. And honestly, if the link is to a Steam page directly, you probably do NOT need to run it through your link filter anyway.
Sist redigert av Kaedys; 27. juni 2023 kl. 8.59
< >
Viser 17 av 7 kommentarer
Crazy Tiger 27. juni 2023 kl. 9.04 
Or people can simply leave a space between the link and the () when they post, it doesn't happen then.
Kaedys 27. juni 2023 kl. 9.22 
Sure, but why should users be required to leave an extra junk space simply because Steam's link parser is objectively doing it wrong?
cSg|mc-Hotsauce 27. juni 2023 kl. 9.24 
Don't wrap links. It is the same on the forums.

:qr:
Kaedys 27. juni 2023 kl. 9.26 
Again, you're literally arguing that a clear and obvious bug doesn't need to be fixed simply because there are workarounds. Including links in parentheses is a common thing, and there's zero reason Steam's link parser should not be able to handle this. Basically every other comment system that automatically parses links handles this just fine, so Steam should too. Defending the existence of a bug simply because it can be avoided by restructuring one's comment around that bug's existence is actual lunacy.
cSg|mc-Hotsauce 27. juni 2023 kl. 9.29 
Opprinnelig skrevet av Kaedys:
Again, you're literally arguing that a clear and obvious bug doesn't need to be fixed simply because there are workarounds. Including links in parentheses is a common thing, and there's zero reason Steam's link parser should not be able to handle this. Basically every other comment system that automatically parses links handles this just fine, so Steam should too. Defending the existence of a bug simply because it can be avoided by restructuring one's comment around that bug's existence is actual lunacy.

After over a decade, it is no longer a bug but an intentional design feature.

:qr:
Kaedys 27. juni 2023 kl. 9.30 
Y'all are LongTimeUser4 in this comic. Just sayin'.

https://xkcd.com/1172/
Kaedys 27. juni 2023 kl. 9.32 
Also, a bug not being fixed for a long time does not make it an "intentional design feature". It just means they either weren't aware of it, or never bothered to prioritize fixing it. It only becomes intentional if they actually looked at it at one point and said "no, it should work that way". And tbh, if someone at Valve did do that, they do not belong anywhere near an IDE, ever.
< >
Viser 17 av 7 kommentarer
Per side: 1530 50

Dato lagt ut: 27. juni 2023 kl. 8.55
Innlegg: 7