[1.5.8] Crash when loading a saved game

[mad kitten]

I've seen this many times by now, with different saves. Here's a call stack from the debugger.

Here's the complete call stack:

>	mscorlib.dll!System.ThrowHelper.ThrowKeyNotFoundException() Line 68	C#
 	mscorlib.dll!System.Collections.Generic.Dictionary<System.__Canon, float>.this[System.__Canon].get(System.__Canon key) Line 183	C#
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.CaravansCampaignBehavior.CreateFactionPriceData()	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.CaravansCampaignBehavior.GetFactionPriceData()	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.CaravansCampaignBehavior.SellGoods(TaleWorlds.CampaignSystem.MobileParty caravanParty, TaleWorlds.CampaignSystem.Town town, float priceIndexSellLimit, bool toLoseWeight)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.CaravansCampaignBehavior.OnSettlementLeft(TaleWorlds.CampaignSystem.MobileParty mobileParty, TaleWorlds.CampaignSystem.Settlement settlement)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.MbEvent<System.__Canon, System.__Canon>.InvokeList(TaleWorlds.CampaignSystem.MbEvent<System.__Canon, System.__Canon>.EventHandlerRec<System.__Canon, System.__Canon> list, System.__Canon t1, System.__Canon t2)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.CampaignEvents.OnSettlementLeft(TaleWorlds.CampaignSystem.MobileParty party, TaleWorlds.CampaignSystem.Settlement settlement)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.CampaignEventDispatcher.OnSettlementLeft(TaleWorlds.CampaignSystem.MobileParty party, TaleWorlds.CampaignSystem.Settlement settlement)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.Actions.LeaveSettlementAction.ApplyForParty(TaleWorlds.CampaignSystem.MobileParty mobileParty)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.PrisonerCaptureCampaignBehavior.HandleSettlementHeroes(TaleWorlds.CampaignSystem.Settlement settlement)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.PrisonerCaptureCampaignBehavior.OnGameLoaded(TaleWorlds.CampaignSystem.CampaignGameStarter campaignGameStarter)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.MbEvent<System.__Canon>.InvokeList(TaleWorlds.CampaignSystem.MbEvent<System.__Canon>.EventHandlerRec<System.__Canon> list, System.__Canon t)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.CampaignEvents.OnGameLoaded(TaleWorlds.CampaignSystem.CampaignGameStarter campaignGameStarter)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.CampaignEventDispatcher.OnGameLoaded(TaleWorlds.CampaignSystem.CampaignGameStarter campaignGameStarter)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.Campaign.OnGameLoaded(TaleWorlds.CampaignSystem.CampaignGameStarter starter)	Unknown
 	TaleWorlds.CampaignSystem.dll!TaleWorlds.CampaignSystem.Campaign.DoLoadingForGameType(TaleWorlds.Core.GameTypeLoadingStates gameTypeLoadingState, out TaleWorlds.Core.GameTypeLoadingStates nextState)	Unknown
 	StoryMode.dll!StoryMode.CampaignStoryMode.DoLoadingForGameType(TaleWorlds.Core.GameTypeLoadingStates gameTypeLoadingState, out TaleWorlds.Core.GameTypeLoadingStates nextState)	Unknown
 	TaleWorlds.Core.dll!TaleWorlds.Core.GameType.DoLoadingForGameType()	Unknown
 	SandBox.dll!SandBox.CampaignGameManager.DoLoadingForGameManager(TaleWorlds.Core.GameManagerLoadingSteps gameManagerLoadingStep, out TaleWorlds.Core.GameManagerLoadingSteps nextStep)	Unknown
 	TaleWorlds.Core.dll!TaleWorlds.Core.GameManagerBase.DoLoadingForGameManager()	Unknown
 	TaleWorlds.MountAndBlade.dll!TaleWorlds.MountAndBlade.GameLoadingState.OnTick(float dt)	Unknown
 	TaleWorlds.Core.dll!TaleWorlds.Core.GameStateManager.OnTick(float dt)	Unknown
 	TaleWorlds.MountAndBlade.dll!TaleWorlds.MountAndBlade.Module.OnApplicationTick(float dt)	Unknown
 	TaleWorlds.DotNet.dll!TaleWorlds.DotNet.Managed.ApplicationTick(float dt)	Unknown

[mad kitten]

So far as I can see, it crashes on this line:

        float profit = (this._priceDataCreationCache[index1].Item3 - this._priceDataCreationCache[index1].Item4) * this._averageValuesCached[key];

specifically when trying to access _averageValuesCached, because it is empty at this point.

Looks like CreateFactionPriceData() needs to call UpdateAverageValues()?

[jjwalker]

mad kitten の投稿を引用：

So far as I can see, it crashes on this line:

        float profit = (this._priceDataCreationCache[index1].Item3 - this._priceDataCreationCache[index1].Item4) * this._averageValuesCached[key];

specifically when trying to access _averageValuesCached, because it is empty at this point.

Looks like CreateFactionPriceData() needs to call UpdateAverageValues()?

Yeah, it's trying to fetch something that doesn't exist. It's probably a race condition honestly because a cache should be fairly static once it is written to...not a constant but a pre-computed lookup table.

Edit: I re-read it, yeah it's trying to multiply against a lookup table that hasn't been generated yet (to get average market value).

[elysebluemoon]

mad kitten の投稿を引用：

I've seen this many times by now, with different saves. Here's a call stack from the debugger.

Do you have any mods installed? Can you send a crash dump via the crash uploader and post the crash report ID here as instructed below?
https://steamcommunity.com/app/261550/discussions/17/5283252978690800581/
(BSS-1015)

[mad kitten]

FWIW, I've used the crash uploader to report it several times now.

I do have some mods, but the crash is reproducible even once they are disabled. Once a saved game gets into this state, it's a consistent repro.

I just reproduced it again with mods disabled, and uploaded the crash report:

---------------------------
You can use the following identifier if you prefer to seek help in person: 2021-02-08_20.59.06_0061b0ee3bab6731e8586122f53b1cf5 (Copied to clipboard)
---------------------------

Note that the crash report had the wrong savegame file attached. It appears to be attaching the most recent save, but I was actually trying to load an older save. I can provide the correct save that consistently reproduces this issue - just let me know where to send it.

I can also try to debug this locally, if it helps.

[mad kitten]

I found the instructions, and tried to use the file uploader on upload.taleworlds.com according to them. However, once the upload finished, I got this:

Your file was uploaded successfully.

SMTP -> ERROR: DATA not accepted from server: 552-5.2.3 Your message exceeded Google's message size limits. Please visit 552-5.2.3 https://support.google.com/mail/?p=MaxSizeError to view our size 552 5.2.3 guidelines. s123sm2335110vka.37 - gsmtp
SMTP Error: Data not accepted.

So I'm still not sure whether it was uploaded correctly or not.

[elysebluemoon]

Forwarding this issue to the QA team for further investigation. Thanks for reporting.
(BAN-27125)

[mad kitten]

Confirmed fixed in today's 1.5.8 update - thank you!

[elysebluemoon]

Glad to hear it! :)